Skip to content

Fix RegisterExtension double quoted path #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2020
Merged

Fix RegisterExtension double quoted path #177

merged 1 commit into from
Oct 23, 2020

Conversation

GH-Rake
Copy link
Contributor

@GH-Rake GH-Rake commented Oct 23, 2020 •
edited
Loading

In the latest version with all commits, if you you click the Create Association button you get:

Computer\HKEY_CLASSES_ROOT\rcnetfile\DefaultIcon
""C:\ReClass.NET\bin\Release\ReClass.NET_Launcher.exe"",0

Computer\HKEY_CLASSES_ROOT\rcnetfile\shell\open\command
""C:\ReClass.NET\bin\\Release\ReClass.NET_Launcher.exe"" "%1"

The RegisterExtension function results in a double set of quotes surrounding the path. The double set of quotes invalidate the path and breaks the association with the icon and command keys.

Removing these 3 lines fixes it. I tested it on file paths that contain spaces and paths that do not contain spaces in them and this fix works fine for both scenarios.

@KN4CK3R
Copy link
Member

KN4CK3R commented Oct 23, 2020

Great thank you. This error was introduced with 569a590.

@KN4CK3R KN4CK3R merged commit 78d44bd into ReClassNET:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GH-Rake @KN4CK3R