Skip to content

Fix crash when using "Insert Bytes" on the topmost entry #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2021
Merged

Fix crash when using "Insert Bytes" on the topmost entry #209

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4d420d
Fixed a crash where using the 'Insert Bytes' menu on the topmost clas…
ko1N Oct 8, 2021
22d6f30
Disabled 'Insert Bytes' menu when selecting a class
ko1N Oct 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ReClass.NET/Forms/MainForm.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,7 @@ private void selectedNodeContextMenuStrip_Opening(object sender, CancelEventArgs
};

addBytesToolStripMenuItem.Enabled = parentNode != null || nodeIsClass;
insertBytesToolStripMenuItem.Enabled = count == 1 && parentNode != null;
insertBytesToolStripMenuItem.Enabled = count == 1 && parentNode != null && !nodeIsClass;

changeTypeToolStripMenuItem.Enabled = count > 0 && !nodeIsClass;

Expand Down Expand Up @@ -829,11 +829,12 @@ private void memoryViewControl_SelectionChanged(object sender, EventArgs e)

var node = selectedNodes.FirstOrDefault()?.Node;
var parentContainer = node?.GetParentContainer();
var nodeIsClass = node is ClassNode;

addBytesToolStripDropDownButton.Enabled = parentContainer != null || node is ClassNode;
insertBytesToolStripDropDownButton.Enabled = selectedNodes.Count == 1 && parentContainer != null;
addBytesToolStripDropDownButton.Enabled = parentContainer != null || nodeIsClass;
insertBytesToolStripDropDownButton.Enabled = selectedNodes.Count == 1 && parentContainer != null && !nodeIsClass;

var enabled = selectedNodes.Count > 0 && !(node is ClassNode);
var enabled = selectedNodes.Count > 0 && !nodeIsClass;
toolStrip.Items.OfType<TypeToolStripButton>().ForEach(b => b.Enabled = enabled);
}

Expand Down