Skip to content

Update README.md #16107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2025
Merged

Update README.md #16107

merged 1 commit into from
Jul 30, 2025

Conversation

pallavigitwork
Copy link
Member

@pallavigitwork pallavigitwork commented Jul 30, 2025

User description

Removed line Javascript API document generation is broken. i saw the github issue states its fixed and checked the api link.

🔗 Related Issues

💥 What does this PR do?

Removed the line that Javascript API doc generation is broken, the github issue listed shows its fixed and the link is fixed.

🔧 Implementation Notes

💡 Additional Considerations

🔄 Types of changes

  • Cleanup (formatting, renaming)
  • Bug fix (backwards compatible)
  • New feature (non-breaking change which adds functionality and tests!)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR Type

Documentation


Description

  • Remove outdated note about broken JavaScript API documentation

File Walkthrough

Relevant files
Documentation
README.md
Remove broken JavaScript docs note                                             

README.md

  • Removed outdated note stating JavaScript API documentation generation
    is broken
+0/-2     

Removed line Javascript API document generation is broken. i saw the github issue states its fixed and checked the api link.
@pallavigitwork pallavigitwork self-assigned this Jul 30, 2025
Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ❌

5678 - Not compliant

Non-compliant requirements:

• Fix ConnectFailure (Connection refused) error when instantiating ChromeDriver
• Error occurs for all instances after the first ChromeDriver instantiation
• Issue affects Ubuntu 16.04.4, Chrome 65.0.3325.181, ChromeDriver 2.35, Selenium 3.9.0

1234 - Not compliant

Non-compliant requirements:

• Fix JavaScript execution in link's href attribute when using click() method
• Issue affects Firefox 42.0 with Selenium 2.48.0 and 2.48.2
• JavaScript should trigger properly on click events

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

Copy link
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

@pallavigitwork
Copy link
Member Author

#10185

Copy link
Contributor

@cgoldberg cgoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cgoldberg cgoldberg merged commit 7407515 into SeleniumHQ:trunk Jul 30, 2025
11 checks passed
@pallavigitwork
Copy link
Member Author

thank you @cgoldberg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants