-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[dotnet] Remove long awaited obsolete members #16121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dotnet] Remove long awaited obsolete members #16121
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes long-awaited obsolete members from the .NET Selenium bindings as part of a cleanup effort. The changes focus on removing deprecated constructors, properties, and methods that have been marked as obsolete across various components.
- Remove obsolete DevTools session methods and constructors that used integer protocol versions
- Remove deprecated property aliases like
WhitelistedIPAddresses
andBrowserExecutableLocation
- Delete the entire obsolete
ConsoleLogHandler
class
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
ChromiumDriver.cs | Remove obsolete DevTools session method with integer protocol version |
ChromiumDriverService.cs | Remove deprecated WhitelistedIPAddresses property alias |
DevToolsSession.cs | Remove obsolete constructor overload without options parameter |
IDevTools.cs | Remove obsolete DevTools interface method with integer protocol version |
EdgeDriverService.cs | Remove deprecated UseVerboseLogging property alias |
FirefoxOptions.cs | Remove obsolete BrowserExecutableLocation property alias |
ActionSequence.cs | Remove deprecated inputDevice property with lowercase naming |
ConsoleLogHandler.cs | Delete entire obsolete logging handler class |
RemoteWebDriver.cs | Remove obsolete DevTools session method with integer protocol version |
UserAgent.cs | Remove obsolete parameterless constructor |
Well done. |
User description
Remove obsolete members, finally.
🔄 Types of changes
PR Type
Other
Description
Remove obsolete methods and properties from .NET bindings
Clean up deprecated DevTools session constructors
Remove legacy property aliases and deprecated logging handlers
Diagram Walkthrough
File Walkthrough
10 files
Remove obsolete DevTools session method
Remove deprecated WhitelistedIPAddresses property
Remove obsolete constructor overload
Remove obsolete DevTools interface methods
Remove deprecated UseVerboseLogging property
Remove obsolete BrowserExecutableLocation property
Remove deprecated inputDevice property
Delete entire obsolete logging handler class
Remove obsolete DevTools session method
Remove obsolete parameterless constructor