Skip to content

Enabling two FF driver tests #2401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions examples/dotnet/SeleniumDocs/Browsers/FirefoxTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,13 @@
{
File.Delete(_tempPath);
}
driver.Quit();
try
{
driver.Quit();
}
catch (WebDriverException)
{
}
}

[TestMethod]
Expand Down Expand Up @@ -56,13 +62,13 @@
}

[TestMethod]
[Ignore("Not implemented")]
public void LogsToFile()
{
var service = FirefoxDriverService.CreateDefaultService();
//service.LogFile = _logLocation
service.LogPath = GetLogLocation();

Check failure on line 68 in examples/dotnet/SeleniumDocs/Browsers/FirefoxTest.cs

View workflow job for this annotation

GitHub Actions / tests (macos, stable)

'FirefoxDriverService' does not contain a definition for 'LogPath' and no accessible extension method 'LogPath' accepting a first argument of type 'FirefoxDriverService' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 68 in examples/dotnet/SeleniumDocs/Browsers/FirefoxTest.cs

View workflow job for this annotation

GitHub Actions / tests (macos, stable)

'FirefoxDriverService' does not contain a definition for 'LogPath' and no accessible extension method 'LogPath' accepting a first argument of type 'FirefoxDriverService' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 68 in examples/dotnet/SeleniumDocs/Browsers/FirefoxTest.cs

View workflow job for this annotation

GitHub Actions / tests (macos, stable)

'FirefoxDriverService' does not contain a definition for 'LogPath' and no accessible extension method 'LogPath' accepting a first argument of type 'FirefoxDriverService' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 68 in examples/dotnet/SeleniumDocs/Browsers/FirefoxTest.cs

View workflow job for this annotation

GitHub Actions / tests (ubuntu, stable)

'FirefoxDriverService' does not contain a definition for 'LogPath' and no accessible extension method 'LogPath' accepting a first argument of type 'FirefoxDriverService' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 68 in examples/dotnet/SeleniumDocs/Browsers/FirefoxTest.cs

View workflow job for this annotation

GitHub Actions / tests (ubuntu, stable)

'FirefoxDriverService' does not contain a definition for 'LogPath' and no accessible extension method 'LogPath' accepting a first argument of type 'FirefoxDriverService' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 68 in examples/dotnet/SeleniumDocs/Browsers/FirefoxTest.cs

View workflow job for this annotation

GitHub Actions / tests (ubuntu, stable)

'FirefoxDriverService' does not contain a definition for 'LogPath' and no accessible extension method 'LogPath' accepting a first argument of type 'FirefoxDriverService' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 68 in examples/dotnet/SeleniumDocs/Browsers/FirefoxTest.cs

View workflow job for this annotation

GitHub Actions / tests (windows, stable)

'FirefoxDriverService' does not contain a definition for 'LogPath' and no accessible extension method 'LogPath' accepting a first argument of type 'FirefoxDriverService' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 68 in examples/dotnet/SeleniumDocs/Browsers/FirefoxTest.cs

View workflow job for this annotation

GitHub Actions / tests (windows, stable)

'FirefoxDriverService' does not contain a definition for 'LogPath' and no accessible extension method 'LogPath' accepting a first argument of type 'FirefoxDriverService' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 68 in examples/dotnet/SeleniumDocs/Browsers/FirefoxTest.cs

View workflow job for this annotation

GitHub Actions / tests (windows, stable)

'FirefoxDriverService' does not contain a definition for 'LogPath' and no accessible extension method 'LogPath' accepting a first argument of type 'FirefoxDriverService' could be found (are you missing a using directive or an assembly reference?)

driver = new FirefoxDriver(service);
driver.Quit();
var lines = File.ReadLines(GetLogLocation());
Assert.IsNotNull(lines.FirstOrDefault(line => line.Contains("geckodriver INFO Listening on")));
}
Expand All @@ -85,15 +91,14 @@
}

[TestMethod]
[Ignore("You can set it, just can't see it")]
public void LogsLevel()
{
var service = FirefoxDriverService.CreateDefaultService();
//service.LogFile = _logLocation

service.LogPath = GetLogLocation();

Check failure on line 97 in examples/dotnet/SeleniumDocs/Browsers/FirefoxTest.cs

View workflow job for this annotation

GitHub Actions / tests (macos, stable)

'FirefoxDriverService' does not contain a definition for 'LogPath' and no accessible extension method 'LogPath' accepting a first argument of type 'FirefoxDriverService' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 97 in examples/dotnet/SeleniumDocs/Browsers/FirefoxTest.cs

View workflow job for this annotation

GitHub Actions / tests (macos, stable)

'FirefoxDriverService' does not contain a definition for 'LogPath' and no accessible extension method 'LogPath' accepting a first argument of type 'FirefoxDriverService' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 97 in examples/dotnet/SeleniumDocs/Browsers/FirefoxTest.cs

View workflow job for this annotation

GitHub Actions / tests (macos, stable)

'FirefoxDriverService' does not contain a definition for 'LogPath' and no accessible extension method 'LogPath' accepting a first argument of type 'FirefoxDriverService' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 97 in examples/dotnet/SeleniumDocs/Browsers/FirefoxTest.cs

View workflow job for this annotation

GitHub Actions / tests (ubuntu, stable)

'FirefoxDriverService' does not contain a definition for 'LogPath' and no accessible extension method 'LogPath' accepting a first argument of type 'FirefoxDriverService' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 97 in examples/dotnet/SeleniumDocs/Browsers/FirefoxTest.cs

View workflow job for this annotation

GitHub Actions / tests (ubuntu, stable)

'FirefoxDriverService' does not contain a definition for 'LogPath' and no accessible extension method 'LogPath' accepting a first argument of type 'FirefoxDriverService' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 97 in examples/dotnet/SeleniumDocs/Browsers/FirefoxTest.cs

View workflow job for this annotation

GitHub Actions / tests (ubuntu, stable)

'FirefoxDriverService' does not contain a definition for 'LogPath' and no accessible extension method 'LogPath' accepting a first argument of type 'FirefoxDriverService' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 97 in examples/dotnet/SeleniumDocs/Browsers/FirefoxTest.cs

View workflow job for this annotation

GitHub Actions / tests (windows, stable)

'FirefoxDriverService' does not contain a definition for 'LogPath' and no accessible extension method 'LogPath' accepting a first argument of type 'FirefoxDriverService' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 97 in examples/dotnet/SeleniumDocs/Browsers/FirefoxTest.cs

View workflow job for this annotation

GitHub Actions / tests (windows, stable)

'FirefoxDriverService' does not contain a definition for 'LogPath' and no accessible extension method 'LogPath' accepting a first argument of type 'FirefoxDriverService' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 97 in examples/dotnet/SeleniumDocs/Browsers/FirefoxTest.cs

View workflow job for this annotation

GitHub Actions / tests (windows, stable)

'FirefoxDriverService' does not contain a definition for 'LogPath' and no accessible extension method 'LogPath' accepting a first argument of type 'FirefoxDriverService' could be found (are you missing a using directive or an assembly reference?)
service.LogLevel = FirefoxDriverLogLevel.Debug;

driver = new FirefoxDriver(service);
driver.Quit();
var lines = File.ReadLines(GetLogLocation());
Assert.IsNotNull(lines.FirstOrDefault(line => line.Contains("Marionette\tDEBUG")));
}
Expand Down Expand Up @@ -171,7 +176,7 @@

private string GetLogLocation()
{
if (_logLocation != null && !File.Exists(_logLocation))
if (string.IsNullOrEmpty(_logLocation) && !File.Exists(_logLocation))
{
_logLocation = Path.GetTempFileName();
}
Expand Down
Loading