Skip to content

Added CSendProxyRecipients function definitions to undefined_symbols.h. #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 10, 2020

Conversation

CookStar
Copy link
Contributor

@CookStar CookStar commented Dec 8, 2020

Fixed this error.

[Source.Python] Loading...
=========================================================================
[SP-LOADER] Could not load library: bin/core.so
[SP-LOADER] Error Reported: /home/steam/csgo_ds/csgo/addons/source-python/bin/core.so: undefined symbol: _ZN20CSendProxyRecipients12SetRecipientEi
=========================================================================
Failed to load plugin "addons/source-python"

Added Parts:

inline void CSendProxyRecipients::SetRecipient( int iClient )
{
m_Bits.Set( iClient );
}
inline void CSendProxyRecipients::ClearRecipient( int iClient )
{
m_Bits.Clear( iClient );
}
inline void CSendProxyRecipients::SetOnly( int iClient )
{
m_Bits.ClearAll();
m_Bits.Set( iClient );
}

@CookStar CookStar changed the title Added missing functions in the header file. Added missing SendProxyRecipients functions in the header file. Dec 8, 2020
@jordanbriere
Copy link
Contributor

Fixed this error.

Thanks! However, no need to patch the whole file for missing symbols. Just add them to undefined_symbols.h. :)

@CookStar
Copy link
Contributor Author

CookStar commented Dec 8, 2020

Fixed this error.

Thanks! However, no need to patch the whole file for missing symbols. Just add them to undefined_symbols.h. :)

Since all functions are inline member functions, this does not work.

@Ayuto
Copy link
Member

Ayuto commented Dec 8, 2020

Oh, I should have tested that. Thanks!

But you don't need to make them inline functions. Then adding them to the undefined symbols should work fine :)

@CookStar
Copy link
Contributor Author

CookStar commented Dec 8, 2020

But you don't need to make them inline functions. Then adding them to the undefined symbols should work fine :)

Okay.

@CookStar CookStar changed the title Added missing SendProxyRecipients functions in the header file. Added CSendProxyRecipients function definitions to undefined_symbols.h. Dec 9, 2020
@jordanbriere jordanbriere merged commit 5d02e54 into Source-Python-Dev-Team:master Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants