This repository was archived by the owner on Sep 8, 2020. It is now read-only.
Improvements to Atom conversion. #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solidspark
added a commit
that referenced
this pull request
Feb 28, 2014
Improvements to Atom conversion.
|
Thanks for this! Released as https://github.com/angular-ui/AngularJS-Atom/releases/tag/0.0.3 |
|
I would actually prefer not to see a semicolon as the terminator, but instead move the cursor to this position. This way the user can decide to add the semicolon and carriage return themself OR they can simply add a dot and continue chaining. The semicolon is also not used in coffeescript. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few small issues from the Textmate conversion.
$TM_JAVASCRIPT_TERMINATORwith semi-colons$s in the snippet body'.text.html, .meta.tag':to fix the html snippets