Skip to content

#26584: Remove css rule #31579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cmddog
Copy link

@cmddog cmddog commented Jul 22, 2025

Fixes the bug brought up in #26584 by removing the css rule, causing chips to once again truncate text correctly as intended, rather than overflowing.

@cmddog cmddog requested a review from a team as a code owner July 22, 2025 18:19
@cmddog cmddog requested review from adolgachev and wagnermaciel and removed request for a team July 22, 2025 18:19
@adolgachev adolgachev requested a review from crisbeto July 24, 2025 16:24
Copy link
Contributor

@adolgachev adolgachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, this has internal implications within Google which prevent this being fixed with just this change. But we will bump it up in priority and take a look to see if we can make the change and mitigate it internally.

In the mean-time, please reference the workarounds in the referenced bugs.

And thank you in any case for your proposed contribution.

@cmddog
Copy link
Author

cmddog commented Jul 31, 2025

@adolgachev I see - I did end up using the ::ng-deep workaround to override the rule in our project, but for obvious reasons I don't particularly like using ng-deep. In any case, thank you for the quick response and looking into the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants