Ethernet library: add missing functions #160
Open
+1,983
−259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+52
to
+62
| void MACAddress(uint8_t *mac_address); | ||
| IPAddress localIP(); | ||
| IPAddress subnetMask(); | ||
| IPAddress gatewayIP(); | ||
| IPAddress dnsServerIP(); | ||
|
|
||
| void setMACAddress(const uint8_t *mac_address); | ||
| void setLocalIP(const IPAddress local_ip); | ||
| void setSubnetMask(const IPAddress subnet); | ||
| void setGatewayIP(const IPAddress gateway); | ||
| void setDnsServerIP(const IPAddress dns_server); |
There was a problem hiding this comment.
We can avoid overloading these methods
| } | ||
| public: | ||
| NetworkInterface() {} | ||
| ~NetworkInterface() {} |
There was a problem hiding this comment.
We should make this virtual
Suggested change
| ~NetworkInterface() {} | |
| virtual ~NetworkInterface() = default; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ethernet)