Skip to content

test(parser): Fixed failing tests after zod version bump to 4.0.14 #4240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2025

Conversation

sdangol
Copy link
Contributor

@sdangol sdangol commented Jul 30, 2025

Summary

This PR bumps the Zod version in the parser package to 4.0.14 and also updates the unit tests to comply with the updated parsing behavior that was introduced by zod.

Changes

Please provide a summary of what's being changed

  • Bumped the zod version to 4.0.14
  • Updated the test for parsing an invalid Cloudwatch log event to check for invalid base64 cases
  • Added another test for parsing an invalid Cloudwatch log event where a valid base64 was passed but contained a malformed JSON structure.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #4210


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@pull-request-size pull-request-size bot added the size/M PR between 30-99 LOC label Jul 30, 2025
@sdangol sdangol self-assigned this Jul 30, 2025
@boring-cyborg boring-cyborg bot added dependencies Changes that touch dependencies, e.g. Dependabot, etc. tests PRs that add or change tests labels Jul 30, 2025
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, can you also bump the zod dependency in the examples/snippets and packages/kafka workspaces? Check if it's used elsewhere with npm ls zod

Copy link

Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dreamorosi dreamorosi merged commit 6bacb24 into main Jul 31, 2025
46 checks passed
@dreamorosi dreamorosi deleted the test/parser-zodpipe branch July 31, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes that touch dependencies, e.g. Dependabot, etc. size/M PR between 30-99 LOC tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: review zod update
3 participants