refactor(logger): replace EnvironmentVariablesService class with helper functions #4251
Conversation
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
pull-request-size
bot
added
size/L
|
| @@ -169,6 +182,21 @@ describe('Class: EnvironmentVariablesService', () => { | |||
| expect(value).toEqual(0.01); | |||
| }); | |||
|
|
|||
| it.each([undefined, ''])( | |||
There was a problem hiding this comment.
Since we removed all usage of EnvironmentVariablesService from the Logger class, we should also remove the files for the EnvironmentVariablesService itself - this should also make this test redundant.
There was a problem hiding this comment.
in order to fully remove EnvironmentVariablesService class from Logger, I think we need to remove it from PowertoolsLogFormatter constructor and so also refactor LogFormatter. I was not sure if this was expected on this PR, but sure I can do it just let me know
There was a problem hiding this comment.
Hi sorry if the issue wasn't clear- yes, please, let's do that too if you don't mind!
Summary
Changes
This PR removes the legacy class-based EnvironmentVariablesService methods from the Logger package.
Issue number: closes #4116
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.