Skip to content

refactor: centralize type definitions in dedicated types.lua module #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ThomasK33
Copy link
Member

Centralize type definitions in a dedicated module

This PR introduces a new types.lua module that centralizes all type definitions for the ClaudeCode.nvim plugin. The change:

  • Creates a dedicated lua/claudecode/types.lua file containing all public API types
  • Removes inline type definitions from config.lua, init.lua, and logger.lua
  • Updates type references across the codebase to use the new centralized types
  • Improves type naming consistency with the ClaudeCode prefix (e.g., ClaudeCodeConfig instead of ClaudeCode.Config)
  • Enhances type documentation with more detailed descriptions

This change makes the type system more maintainable and provides a single source of truth for the plugin's API types.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ThomasK33 ThomasK33 marked this pull request as ready for review August 5, 2025 12:32
@ThomasK33 ThomasK33 force-pushed the thomask33/refactor_centralize_type_definitions_in_dedicated_types.lua_module branch from eaaf586 to 25fdb84 Compare August 5, 2025 12:46
Change-Id: Idfbb1d15fac498475ddc517f85f86838cb19322c
Signed-off-by: Thomas Kosiewski <tk@coder.com>
@ThomasK33 ThomasK33 force-pushed the thomask33/refactor_centralize_type_definitions_in_dedicated_types.lua_module branch from 25fdb84 to cecaf9d Compare August 5, 2025 12:48
Copy link
Member Author

ThomasK33 commented Aug 5, 2025

Merge activity

  • Aug 5, 2:44 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Aug 5, 2:44 PM UTC: @ThomasK33 merged this pull request with Graphite.

@ThomasK33 ThomasK33 merged commit d73a464 into main Aug 5, 2025
4 checks passed
@ThomasK33 ThomasK33 deleted the thomask33/refactor_centralize_type_definitions_in_dedicated_types.lua_module branch August 5, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant