Skip to content

fix: JSDoc @example parsing issue #1584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 51 commits into
base: develop
Choose a base branch
from
Open

fix: JSDoc @example parsing issue #1584

wants to merge 51 commits into from

Conversation

tcorral
Copy link

@tcorral tcorral commented Jul 7, 2025

No description provided.

@tcorral
Copy link
Author

tcorral commented Jul 10, 2025

@vogloblinsky Could you take a look to this PR, please?

@tcorral
Copy link
Author

tcorral commented Jul 10, 2025

This PR solves:

@tcorral tcorral changed the title Fix JSDoc @example parsing issue fix: JSDoc @example parsing issue Jul 11, 2025
@vogloblinsky
Copy link
Contributor

Hi,
I have difficulties to review the PR, many diff issues due to linting configuration.
Could you revert it ?
Thanks

@tcorral
Copy link
Author

tcorral commented Jul 14, 2025

Hi, I have difficulties to review the PR, many diff issues due to linting configuration. Could you revert it ? Thanks

Are the linting changes not needed?

@vogloblinsky
Copy link
Contributor

Hi, I have difficulties to review the PR, many diff issues due to linting configuration. Could you revert it ? Thanks

Are the linting changes not needed?

yes it is easier to review the PR, thanks

Tomas Corral Casas added 18 commits July 14, 2025 19:38
Rever linting issues in src/app/compiler/angular/deps/component-dep.f…
e405f73 
…actory.ts
Rever linting issues in src/app/compiler/angular/deps/component-dep.f…
6cd09b0 
…actory.ts
Revert linting issues in src/app/compiler/angular/deps/directive-dep.…
51494e3 
…factory.ts
Revert linting issues in src/app/compiler/angular/deps/helpers/compon…
45f7724 
…ent-helper.ts
Revert linting issues in src/app/compiler/angular/deps/helpers/compon…
7003dfe 
…ent-helper.ts
Revert linting issues in src/app/compiler/angular/deps/helpers/symbol…
2cc8948 
…-helper.ts
Revert linting issues in src/app/compiler/angular/deps/helpers/symbol…
d3395b0 
…-helper.ts
Revert linting issues in src/app/configuration.ts
8c4cf59
Revert linting issues in src/app/engines/html-engine-helpers/strip-ur…
1b6ba2d 
…l.helper.ts
Revert formatting issues in src/locales/ka-GE.ts
07eab37
Revert linting issues in src/utils/angular-lifecycles-hooks.ts
7944bab
Revert linting issues in src/utils/angular-version.util.ts
c7497f1
Remove linting issues in src/utils/basic-type.util.ts
4307709
Remove linting issues in src/utils/basic-type.util.ts
15b0998
Remove linting issue in src/utils/get-module-with-providers.ts
1b9d30f
Revert linting issues in src/utils/imports.util.ts
89af744
Revert linting issues in src/utils/imports.util.ts
a11f40b
Revert linting issues in src/utils/is-module-with-providers.ts
e18ad9e
Tomas Corral Casas added 19 commits July 14, 2025 20:09
Revert linting issues in src/utils/jsdoc-parser.util.ts
aa9f973
Remove linting issues in src/utils/kind-to-type.ts
8dd7d4c
Revert linting issues in src/utils/link-parser.ts
963c7b8
Revert linting issues in src/utils/link-parser.ts
34af7bd
Revert linting issues in src/utils/link-parser.ts
b4024c9
Revert linting issues in src/utils/link-parser.ts
874d3de
Revert linting issues in src/utils/logger.ts
ea2ecd2
Revert linting issues in src/utils/logger.ts
6d4c80d
Revert linting issues in src/utils/node.util.ts
b8b2579
Revert linting issues in src/utils/promise-sequential.ts
e7aced6
Revert linting issues in src/utils/promise-sequential.ts
668de5f
Revert linting issues in src/utils/router-parser.util.ts
b4807cc
Revert linting issues in src/utils/router-parser.util.ts
fa9a4b2
Revert linting issues in src/utils/router-parser.util.ts
d2a5f12
Revert linting issues in src/utils/router-parser.util.ts
ae197e6
Revert linting issues in src/utils/ts-internal.ts
59f111c
Revert linting issues in src/utils/utils.ts
256bb9d
Revert linting issues in src/utils/utils.ts
05153d7
Fix issues after removing linting fixes
55b9300
@tcorral
Copy link
Author

tcorral commented Jul 14, 2025

I have reverted the linting issues, can you check again @vogloblinsky ?

@tcorral
Copy link
Author

tcorral commented Jul 14, 2025

@vogloblinsky Are you interested on another PR fixing the linting and the format issues or not?

@tcorral
Copy link
Author

tcorral commented Jul 23, 2025

@vogloblinsky Is there anything else I can do to help you moving this PR forward?

1 similar comment
@tcorral
Copy link
Author

tcorral commented Aug 1, 2025

@vogloblinsky Is there anything else I can do to help you moving this PR forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tcorral @vogloblinsky