Skip to content

docs: remove loading dialog section from quickstart guide #2585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

sy-records
Copy link
Member

Summary

After merging #1466, I discovered #1458 (comment).

It seems that data-app does not currently have any practical use? And there is a new Loading.

Perhaps data-app is used in Vue. However, I tested it without adding it, and it worked fine.

So I removed this part of the content.

Related issue, if any:

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

For any code change,

  • Related documentation has been updated, if needed
  • Related tests have been added or updated, if needed

Does this PR introduce a breaking change?

  • Yes
  • No

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge

Copy link

vercel bot commented Jul 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2025 7:39am

Copy link
Member

@Koooooo-7 Koooooo-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the v4, the Loading dialog support customize the Loading content even inserting DOMs.

<div id="app"> I'm loading ... </div>

For now when we change the content, we'll see the loading effect and the content mess up.
I suppose we should have a fix on it...

@sy-records
Copy link
Member Author

Modifying it requires adding some styles.

#app {
display: flex;
align-items: center;
justify-content: center;
gap: 0.75em;
height: 100vh;
padding-inline: 50px;
}

There is a new loading screen in v5. I think we can remove it without fixing it.

@Koooooo-7
Copy link
Member

There is a new loading screen in v5. I think we can remove it without fixing it.

Cuz I thought it was a feature in v4 that user can customize the loading page easily.
I'm ok with it to remove this feature, if user urges to add it back, we could refine it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants