Fixed Shell.NavBarHasShadow on Android #20188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
jsuarezruiz
added
area-controls-shell
jsuarezruiz
reviewed
Jan 29, 2024
| @@ -101,6 +101,11 @@ void OnToggleFlyoutBackgroundColor(object sender, EventArgs e) | |||
| flyoutBackgroundColor.Background = AppShell.FlyoutBackground; | |||
| } | |||
|
|
|||
| void OnToggleNavBarHasShadow(object sender, EventArgs e) | |||
| { | |||
| Shell.SetNavBarHasShadow(this, !Shell.GetNavBarHasShadow(this)); | |||
There was a problem hiding this comment.
Updated the Shell sample to easily test the NavBarHasShadow property.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
reviewed
Feb 21, 2024
| [Theory] | ||
| [InlineData(true)] | ||
| [InlineData(false)] | ||
| public async Task CanHideNavBarShadow(bool navBarHasShadow) |
jsuarezruiz
previously approved these changes
Feb 21, 2024
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
requested changes
Feb 22, 2024
| @@ -561,15 +561,15 @@ void UpdateNavBarHasShadow(Page page) | |||
| if (page == null || !_appBar.IsAlive()) | |||
| return; | |||
|
|
|||
| // 4 is the default | |||
| _appBarElevation = _appBar.Context.ToPixels(4); | |||
There was a problem hiding this comment.
The point of the original code was to reduce the amount of calls to _appBar.Context. The original code did a really bad job of it :-)
Maybe something like this? I think this is what the original author was intending.
if (Shell.GetNavBarHasShadow(page))
{
if (_appBarElevation <= 0)
_appBarElevation = _appBar.Context.ToPixels(4);
_appBar.SetElevation(_appBarElevation);
}
else
{
// 4 is the default
_appBar.SetElevation(0f);
}
|
Failing tests unrelated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixed Shell.NavBarHasShadow on Android
Issues Fixed
Fixes #19458
Screen.Recording.2024-01-27.at.01.14.23.mov