Fix up relevant CA1416 warnings - Set 1 #26696

Tamilarasan-Paranthaman · 2024-12-18T09:35:32Z

Description of Change

The CA1416 warnings were already resolved in PR #26593

In this PR, we have divided the file changes from that PR into smaller groups and included test cases for the affected areas to ensure proper functionality.

Additionally, due to changes in the BrushExtensions file, the NavigationBarBackgroundShouldChange UI test case failed. I resolved this by adjusting the size calculation as suggested in the documentation.

UIGraphicsImageRenderer: https://developer.apple.com/documentation/uikit/uigraphicsimagerenderer
UIGraphicsImageRendererFormat: https://developer.apple.com/documentation/uikit/uigraphicsimagerendererformat

dotnet-policy-service · 2024-12-18T09:35:56Z

Hey there @Tamilarasan-Paranthaman! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

StephaneDelcroix · 2025-01-10T09:08:52Z

/azp run

jfversluis · 2025-02-22T14:38:33Z

@Tamilarasan-Paranthaman are you sure this PR has the right description and title? I don't see any changes related to CA1416

Tamilarasan-Paranthaman · 2025-02-24T07:40:42Z

@Tamilarasan-Paranthaman are you sure this PR has the right description and title? I don't see any changes related to CA1416

@jfversluis , as mentioned in the description, in this PR, I have divided the CA1416 warning fix file changes from the previous PR #26593 into smaller groups, identified the affected cases, and included test cases to ensure proper functionality. So, I have categorized them into different sets

jfversluis · 2025-02-26T07:20:13Z

Could it be that some need a new snapshot or something here? I've retried 4 times but things keep failing, can you have a look @Tamilarasan-Paranthaman?

Tamilarasan-Paranthaman · 2025-02-27T11:41:40Z

Could it be that some need a new snapshot or something here? I've retried 4 times but things keep failing, can you have a look @Tamilarasan-Paranthaman?

@jfversluis, I have resaved the Mac images, and a recently added test failed due to these changes on iOS. I have now fixed the issue. Could you please review and let me know if you have any concerns?

azure-pipelines · 2025-03-05T09:03:09Z

Azure Pipelines successfully started running 3 pipeline(s).

Tamilarasan-Paranthaman · 2025-05-28T07:17:02Z

@Tamilarasan-Paranthaman can you please rebase, there are some conflicts. Maybe target this to the inflight branch too.

@rmarinho, I have rebased the branch, resolved the conflicts, and changed the target to the inflight/current branch. Please take a look and let me know if you have any concerns.

rmarinho · 2025-05-28T09:39:59Z

/azp run

azure-pipelines · 2025-05-28T09:40:20Z

Azure Pipelines successfully started running 3 pipeline(s).

* Changed Syncfusion toolkit version from 1.0.4 to 1.0.5 (#29659) * [ci] Update dependencies from 9.0.4 to 9.0.5 (#29667) * [ci] Update dependencies from 9.0.4 to 9.0.5 * Update the net8 version * Add missing version MicrosoftJSInteropPackageVersion * Page.OnBackButtonPressed remove outdated API documentation (#29543) * Fixed KeepLastItemInView Does Not Scroll to Last Item When Adding Items at Top (#29632) * Fixed KeepLastItem not scrolled to last item * Updated Fix * Updated test sample * Added comment line * Updated test sample for iOS and mac * Added Snapshots for android and WinUI * Added UI tests. * Test sample changes. * script changes * script changes * Added snapshots * Resaved Mac images and the gradient image size issue has been fixed * CA1416 warning changes * Reverted unwanted changes --------- Co-authored-by: Paul Anderson <42271912+PaulAndersonS@users.noreply.github.com> Co-authored-by: Rui Marinho <me@ruimarinho.net> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Dhivya-SF4094 <127717131+Dhivya-SF4094@users.noreply.github.com>

#25393) * [create-pull-request] automated change (#29793) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Convert HybridWebView.js to TypeScript and embed (#27183) * Fix up relevant CA1416 warnings - Set 3 (#26751) * [Testing] Feature Matrix UITest Cases for CollectionView Dynamic changes (#29424) * Added FeatureTests for CollectionView * changes updated * changes updated * [create-pull-request] automated change (#29505) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * CA1416 warning fix * Added snapshots * Reverting files changes * Removed the old approach * Revert unwanted changes * Reverted unwanted changes * Reverted unwanted changes * Revert unwanted changes --------- Co-authored-by: NafeelaNazhir <nafeela.nazhirhussain@syncfusion.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fix up relevant CA1416 warnings - Set 1 (#26696) * Changed Syncfusion toolkit version from 1.0.4 to 1.0.5 (#29659) * [ci] Update dependencies from 9.0.4 to 9.0.5 (#29667) * [ci] Update dependencies from 9.0.4 to 9.0.5 * Update the net8 version * Add missing version MicrosoftJSInteropPackageVersion * Page.OnBackButtonPressed remove outdated API documentation (#29543) * Fixed KeepLastItemInView Does Not Scroll to Last Item When Adding Items at Top (#29632) * Fixed KeepLastItem not scrolled to last item * Updated Fix * Updated test sample * Added comment line * Updated test sample for iOS and mac * Added Snapshots for android and WinUI * Added UI tests. * Test sample changes. * script changes * script changes * Added snapshots * Resaved Mac images and the gradient image size issue has been fixed * CA1416 warning changes * Reverted unwanted changes --------- Co-authored-by: Paul Anderson <42271912+PaulAndersonS@users.noreply.github.com> Co-authored-by: Rui Marinho <me@ruimarinho.net> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Dhivya-SF4094 <127717131+Dhivya-SF4094@users.noreply.github.com> * [iOS/Mac]Fix StrokeDashArray Property not Rendering (#29670) * fix added * Test added * snap added * [Android/ iOS] Fix Flyout icon is displayed when flyout is disabled (#29637) * fix added * modified the fix * test case added * test case added * summary added * Script name changed * [Android & iOS] Fix for SearchHandler Character Spacing Property (#29497) * [Android & iOS] Fix for character spacing in searchHandler * Updated test sample concerns * Update on naming * Update on formatting * Allowing updating character spacing to zero * Updated Andorid, iOS, Mac images * [create-pull-request] automated change (#29724) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [Windows] Fix for SearchHandler Visibility Not Updating During In-Section Navigation (#29441) * fix-17521-Updates the SearchHandler when navigating to another page within same ShellSection. * fix-17521-Added testcase and added snapshot for Android and iOS. * fix-17521-Renamed Shell_Navigated to OnShellNavigated. * fix-17521-Modified the Location string value from "Ethopia" to "Ethiopia". * fix-17521-Snapshot updated. * fix-17521-Updated Windows and Mac Snapshot. * [Windows] - Fix view position shift when shadows are added or removed at runtime (#29681) * Fix-view-position-shift-when-toggling-shadows * Added-Pending-SnapShots * Resaved-image * [Testing] Feature Matrix UITest Cases for Shadows (#27701) * Added sample to Matrix UITest Cases for Shadow * Renamed sample page * Renamed sample page * More tests * More tests * More tests * More tests * Added shadow tests * Updated sample * Added Windows snapshots * Updated tests * Added link to issue * More changes * Updated sample reset logic * Updated sample * More changes * More changes * More changes * Updated sample * Added snapshots * Hide cursor * More changes * More snapshots * Updated tests * Updated iOS snapshots * Updated iOS snapshots * Updated snapshots * Updated snapshots * Updated tests * [housekeeping] Automated PR to fix formatting errors on uitest-shadow-feature * Updated tests * Fix build errors * More changes * More changes * More changes * More changes --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [iOS] Fixed Shell.SearchHandler ClearPlaceholderIcon Color Issue (#28601) * SearchHandler ClearPlaceholderIcon color fix * Added Mac snapshot * Updated SearchBar Icon changes * Test script changes. * Revert unwanted changes * Updated custom icon changes * Fix -[iOS] - CarouselView Throws ArgumentOutOfRangeException Immediately on Application Launch in CV2 (#29316) * Update ItemsSourceFactory2.cs * Update CarouselViewPositionVisibility.xaml * [Windows] Fix for ItemsSource Does Not Dynamically Set to null in CarouselView (#29660) * [Windows] Fix for ItemsSource Does Not Dynamically Set to null in CarouselView * Have added test case * Updated AutomationId for better clarity and readability * Have modified the context of the description label * Have committed the snapshots * [Testing] Feature Matrix UITest Cases for Label (#29690) * Added Label Feature tests * changes updated * changes updated * changes updated * Added Screenshots * Added Snapshots for iOS * Corrected Mistakes * Added snapshots * Added images * Renamed file --------- Co-authored-by: Rui Marinho <me@ruimarinho.net> * updated base images for candidate PR failures (#29766) * [Android] Fix: Modal Animation Repeats When Returning from Background 3 (#29702) * fix * dispose listner once not needed * Revert "dispose listner once not needed" * call invalidate * add device test to check for leaks * null check and remove strong references in callback * Throw if rootview is null before adding animation * fix spelling mistake * [Testing] Include a tolerance parameter in the Verifyscreenshot method (#29776) * Added tolerance parameter to the VerifyScreenshot method * More changes * Update src/Controls/tests/TestCases.Shared.Tests/UITest.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/Controls/tests/TestCases.Shared.Tests/UITest.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * [Testing] Update Appium to v8 (#29774) * Update Appium to the latest version * Removed deprecated logic * Update comment * [create-pull-request] automated change (#29831) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Perf : ButtonContentTypeConverter now using InvariantCulture to parse double --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: Tamilarasan Paranthaman <93904422+Tamilarasan-Paranthaman@users.noreply.github.com> Co-authored-by: NafeelaNazhir <nafeela.nazhirhussain@syncfusion.com> Co-authored-by: Paul Anderson <42271912+PaulAndersonS@users.noreply.github.com> Co-authored-by: Rui Marinho <me@ruimarinho.net> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Dhivya-SF4094 <127717131+Dhivya-SF4094@users.noreply.github.com> Co-authored-by: devanathan-vaithiyanathan <114395405+devanathan-vaithiyanathan@users.noreply.github.com> Co-authored-by: Subhiksha Chandrasekaran <subhiksha.c@syncfusion.com> Co-authored-by: BagavathiPerumal <93652794+BagavathiPerumal@users.noreply.github.com> Co-authored-by: prakashKannanSf3972 <127308739+prakashKannanSf3972@users.noreply.github.com> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: SuthiYuvaraj <92777079+SuthiYuvaraj@users.noreply.github.com> Co-authored-by: SyedAbdulAzeemSF4852 <syedabdulazeem.a@syncfusion.com> Co-authored-by: Anandhan Rajagopal <97146406+anandhan-rajagopal@users.noreply.github.com> Co-authored-by: Bhavanesh N <bhavanesh001@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com>

dotnet-policy-service bot added the community ✨ Community Contribution label Dec 18, 2024

karthikraja-arumugam added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Dec 18, 2024

Tamilarasan-Paranthaman marked this pull request as ready for review December 20, 2024 13:52

Tamilarasan-Paranthaman requested a review from a team as a code owner December 20, 2024 13:52

Tamilarasan-Paranthaman requested review from mattleibow and tj-devel709 December 20, 2024 13:52

This comment was marked as off-topic.

Sign in to view

PureWeen added the area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing label Dec 20, 2024

This comment was marked as off-topic.

Sign in to view

github-actions bot force-pushed the reenable_CA1416_part_1 branch from c46191e to 8cc9a05 Compare February 22, 2025 14:34

jfversluis self-assigned this Feb 22, 2025

This comment was marked as outdated.

Sign in to view

jfversluis added this to the .NET 9 SR5 milestone Feb 22, 2025

This comment was marked as off-topic.

Sign in to view

github-actions bot force-pushed the reenable_CA1416_part_1 branch from 56cd73b to da2513c Compare March 5, 2025 09:02

PureWeen modified the milestones: .NET 9 SR5, .NET 9 SR6 Mar 7, 2025

PureWeen added this to MAUI SDK Ongoing Mar 18, 2025

github-project-automation bot moved this to Todo in MAUI SDK Ongoing Mar 18, 2025

PureWeen moved this from Todo to Ready To Review in MAUI SDK Ongoing Mar 18, 2025

Tamilarasan-Paranthaman added 7 commits May 28, 2025 11:31

Added UI tests.

777696a

Test sample changes.

bc3573a

script changes

c479e59

script changes

1461bc3

Added snapshots

430487f

Resaved Mac images and the gradient image size issue has been fixed

91e4ee9

CA1416 warning changes

a513cbf

Tamilarasan-Paranthaman force-pushed the reenable_CA1416_part_1 branch from 8cfe3e3 to a513cbf Compare May 28, 2025 06:01

Reverted unwanted changes

52d3870

rmarinho merged commit eec75f4 into dotnet:inflight/current May 28, 2025
116 of 129 checks passed

github-project-automation bot moved this from Changes Requested to Done in MAUI SDK Ongoing May 28, 2025

github-actions bot locked and limited conversation to collaborators Jun 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix up relevant CA1416 warnings - Set 1 #26696

Fix up relevant CA1416 warnings - Set 1 #26696

Uh oh!

Tamilarasan-Paranthaman commented Dec 18, 2024 •

edited

Loading

Uh oh!

dotnet-policy-service bot commented Dec 18, 2024

Uh oh!

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

StephaneDelcroix commented Jan 10, 2025 •

edited by jfversluis

Loading

Uh oh!

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as outdated.

jfversluis commented Feb 22, 2025

Uh oh!

Tamilarasan-Paranthaman commented Feb 24, 2025

Uh oh!

jfversluis commented Feb 26, 2025

Uh oh!

Tamilarasan-Paranthaman commented Feb 27, 2025

Uh oh!

This comment was marked as off-topic.

azure-pipelines bot commented Mar 5, 2025

Uh oh!

Tamilarasan-Paranthaman commented May 28, 2025

Uh oh!

rmarinho commented May 28, 2025

Uh oh!

azure-pipelines bot commented May 28, 2025

Uh oh!

Uh oh!

Uh oh!

Fix up relevant CA1416 warnings - Set 1 #26696

Fix up relevant CA1416 warnings - Set 1 #26696

Uh oh!

Conversation

Tamilarasan-Paranthaman commented Dec 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

Uh oh!

dotnet-policy-service bot commented Dec 18, 2024

Uh oh!

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

StephaneDelcroix commented Jan 10, 2025 • edited by jfversluis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as outdated.

jfversluis commented Feb 22, 2025

Uh oh!

Tamilarasan-Paranthaman commented Feb 24, 2025

Uh oh!

jfversluis commented Feb 26, 2025

Uh oh!

Tamilarasan-Paranthaman commented Feb 27, 2025

Uh oh!

This comment was marked as off-topic.

azure-pipelines bot commented Mar 5, 2025

Uh oh!

Tamilarasan-Paranthaman commented May 28, 2025

Uh oh!

rmarinho commented May 28, 2025

Uh oh!

azure-pipelines bot commented May 28, 2025

Uh oh!

Uh oh!

Uh oh!

Tamilarasan-Paranthaman commented Dec 18, 2024 •

edited

Loading

StephaneDelcroix commented Jan 10, 2025 •

edited by jfversluis

Loading