Skip to content

[Android] Fix WebView Navigated is fired when source is null #29234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 15, 2025

Conversation

bhavanesh2001
Copy link
Contributor

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description of Change

LoadUrl is being called even when Source is not set or null

Issues Fixed

Fixes #29233

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Apr 28, 2025
Copy link
Contributor

Hey there @@bhavanesh2001! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@bhavanesh2001 bhavanesh2001 marked this pull request as ready for review April 28, 2025 20:01
@bhavanesh2001 bhavanesh2001 requested a review from a team as a code owner April 28, 2025 20:01
@bhavanesh2001
Copy link
Contributor Author

@jsuarezruiz Could you run pipelines? Also, Please add relevant labels.

@jsuarezruiz jsuarezruiz added the t/bug Something isn't working label Apr 30, 2025
@jsuarezruiz
Copy link
Contributor

/azp run MAUI-UITests-public

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@PureWeen PureWeen changed the base branch from main to inflight/current May 15, 2025 19:58
@PureWeen PureWeen merged commit b8649af into dotnet:inflight/current May 15, 2025
75 of 77 checks passed
PureWeen pushed a commit that referenced this pull request May 21, 2025
* Don't LoadUrl call when source is null

* Add UI Test

* remove space

* Update UI Test
PureWeen pushed a commit that referenced this pull request May 21, 2025
* Don't LoadUrl call when source is null

* Add UI Test

* remove space

* Update UI Test
github-actions bot pushed a commit that referenced this pull request May 22, 2025
* Don't LoadUrl call when source is null

* Add UI Test

* remove space

* Update UI Test
github-actions bot pushed a commit that referenced this pull request May 30, 2025
* Don't LoadUrl call when source is null

* Add UI Test

* remove space

* Update UI Test
github-actions bot pushed a commit that referenced this pull request May 30, 2025
* Don't LoadUrl call when source is null

* Add UI Test

* remove space

* Update UI Test
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-webview WebView community ✨ Community Contribution platform/android t/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android WebView Navigated is fired without setting source
5 participants