-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Android] Fix WebView Navigated is fired when source is null #29234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
PureWeen
merged 4 commits into
dotnet:inflight/current
from
bhavanesh2001:WebView/Navigated
May 15, 2025
Merged
[Android] Fix WebView Navigated is fired when source is null #29234
PureWeen
merged 4 commits into
dotnet:inflight/current
from
bhavanesh2001:WebView/Navigated
May 15, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there @@bhavanesh2001! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
@jsuarezruiz Could you run pipelines? Also, Please add relevant labels. |
/azp run MAUI-UITests-public |
Azure Pipelines successfully started running 1 pipeline(s). |
mattleibow
approved these changes
May 14, 2025
PureWeen
pushed a commit
that referenced
this pull request
May 21, 2025
* Don't LoadUrl call when source is null * Add UI Test * remove space * Update UI Test
PureWeen
pushed a commit
that referenced
this pull request
May 21, 2025
* Don't LoadUrl call when source is null * Add UI Test * remove space * Update UI Test
github-actions bot
pushed a commit
that referenced
this pull request
May 22, 2025
* Don't LoadUrl call when source is null * Add UI Test * remove space * Update UI Test
github-actions bot
pushed a commit
that referenced
this pull request
May 30, 2025
* Don't LoadUrl call when source is null * Add UI Test * remove space * Update UI Test
github-actions bot
pushed a commit
that referenced
this pull request
May 30, 2025
* Don't LoadUrl call when source is null * Add UI Test * remove space * Update UI Test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-controls-webview
WebView
community ✨
Community Contribution
platform/android
t/bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
LoadUrl
is being called even whenSource
is not set ornull
Issues Fixed
Fixes #29233