[NET10.0] Annotate converters for nullability 3/n #29314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartyIX
commented
May 5, 2025
| { | ||
| object ConvertFromInvariantString(string value, IServiceProvider serviceProvider); | ||
| } | ||
| object? ConvertFromInvariantString(string value, IServiceProvider serviceProvider); |
There was a problem hiding this comment.
This is my best guess how it should be annotated based on implementations where
- if
serviceProvideris null, thenArgumentNullExceptionis thrown - if
valuewould be null, then there would be a crash in multiple scenarios.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
MartyIX
force-pushed
the
feature/2025-05-04-Convert-nullability-3-n-NET10
branch
from
330821b to
08a7305
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
rmarinho
approved these changes
May 14, 2025
github-project-automation
bot
moved this from Ready To Review
to Approved
in MAUI SDK Ongoing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
Follow-up to #29276. See #28244 (comment) for details on motivation.
Issues Fixed
Contributes to #28860