Skip to content

[Rule Tuning] Improve Detection Compatibility with Non-English Logs #4410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 23, 2025

Conversation

w0rk3r
Copy link
Contributor

@w0rk3r w0rk3r commented Jan 22, 2025

Issues

Resolves https://github.com/elastic/ia-trade-team/issues/416
Resolves #3397
Resolves https://github.com/elastic/enhancements/issues/20078

Summary

I tested the parsing of event fields in two Active Directory (AD) environments, one using German and another using Japanese. With the exception of the message field, all other fields were populated identically to their English counterparts.

This PR introduces the following changes:

  • Remove event.action redundancy where event.code is specified,
  • Use winlog.event_data.NewUACList instead of the message field.

@w0rk3r w0rk3r added Rule: Tuning tweaking or tuning an existing rule OS: Windows windows related rules Domain: Endpoint backport: auto labels Jan 22, 2025
@w0rk3r w0rk3r self-assigned this Jan 22, 2025
Copy link
Contributor

Rule: Tuning - Guidelines

These guidelines serve as a reminder set of considerations when tuning an existing rule.

Documentation and Context

  • Detailed description of the suggested changes.
  • Provide example JSON data or screenshots.
  • Provide evidence of reducing benign events mistakenly identified as threats (False Positives).
  • Provide evidence of enhancing detection of true threats that were previously missed (False Negatives).
  • Provide evidence of optimizing resource consumption and execution time of detection rules (Performance).
  • Provide evidence of specific environment factors influencing customized rule tuning (Contextual Tuning).
  • Provide evidence of improvements made by modifying sensitivity by changing alert triggering thresholds (Threshold Adjustments).
  • Provide evidence of refining rules to better detect deviations from typical behavior (Behavioral Tuning).
  • Provide evidence of improvements of adjusting rules based on time-based patterns (Temporal Tuning).
  • Provide reasoning of adjusting priority or severity levels of alerts (Severity Tuning).
  • Provide evidence of improving quality integrity of our data used by detection rules (Data Quality).
  • Ensure the tuning includes necessary updates to the release documentation and versioning.

Rule Metadata Checks

  • updated_date matches the date of tuning PR merged.
  • min_stack_version should support the widest stack versions.
  • name and description should be descriptive and not include typos.
  • query should be inclusive, not overly exclusive. Review to ensure the original intent of the rule is maintained.

Testing and Validation

  • Validate that the tuned rule's performance is satisfactory and does not negatively impact the stack.
  • Ensure that the tuned rule has a low false positive rate.


query = '''
event.code:4738 and winlog.api:"wineventlog" and message:"'Don't Require Preauth' - Enabled"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is some context on why we had to use the message field here: #1790 (comment)

PR that fixed the issue and enables us to use winlog.event_data.NewUACList: elastic/integrations#8361


query = '''
event.action:"modified-user-account" and winlog.api:"wineventlog" and event.code:"4738" and
message:"'Don't Expire Password' - Enabled" and not user.id:"S-1-5-18"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is some context on why we had to use the message field here: #1790 (comment)

PR that fixed the issue and enables us to use winlog.event_data.NewUACList: elastic/integrations#8361

Copy link
Contributor

@Samirbous Samirbous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

[any where event.action == "Detailed File Share" and winlog.event_data.RelativeTargetName : "winreg"]
[any where event.code == "5145" and winlog.event_data.RelativeTargetName : "winreg"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to mention this one, Detailed File Share was replaced by network-share-object-access-checked a looong time ago: elastic/integrations#3299

@w0rk3r w0rk3r merged commit fccfafe into main Jan 23, 2025
9 checks passed
@w0rk3r w0rk3r deleted the language_agnostic branch January 23, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport: auto community Domain: Endpoint OS: Windows windows related rules Rule: Tuning tweaking or tuning an existing rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Rule Tuning] Account Configured with Never-Expiring Password
4 participants