-
Notifications
You must be signed in to change notification settings - Fork 588
[Rule Tuning] Improve Detection Compatibility with Non-English Logs #4410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Rule: Tuning - GuidelinesThese guidelines serve as a reminder set of considerations when tuning an existing rule. Documentation and Context
Rule Metadata Checks
Testing and Validation
|
|
||
query = ''' | ||
event.code:4738 and winlog.api:"wineventlog" and message:"'Don't Require Preauth' - Enabled" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is some context on why we had to use the message field here: #1790 (comment)
PR that fixed the issue and enables us to use winlog.event_data.NewUACList
: elastic/integrations#8361
|
||
query = ''' | ||
event.action:"modified-user-account" and winlog.api:"wineventlog" and event.code:"4738" and | ||
message:"'Don't Expire Password' - Enabled" and not user.id:"S-1-5-18" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is some context on why we had to use the message field here: #1790 (comment)
PR that fixed the issue and enables us to use winlog.event_data.NewUACList
: elastic/integrations#8361
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Co-authored-by: Samirbous <64742097+Samirbous@users.noreply.github.com>
…ion-rules into language_agnostic
[any where event.action == "Detailed File Share" and winlog.event_data.RelativeTargetName : "winreg"] | ||
[any where event.code == "5145" and winlog.event_data.RelativeTargetName : "winreg"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to mention this one, Detailed File Share
was replaced by network-share-object-access-checked
a looong time ago: elastic/integrations#3299
Issues
Resolves https://github.com/elastic/ia-trade-team/issues/416
Resolves #3397
Resolves https://github.com/elastic/enhancements/issues/20078
Summary
I tested the parsing of event fields in two Active Directory (AD) environments, one using German and another using Japanese. With the exception of the
message
field, all other fields were populated identically to their English counterparts.This PR introduces the following changes:
event.action
redundancy whereevent.code
is specified,winlog.event_data.NewUACList
instead of the message field.