Add Voting Config Exclusions APIs #4738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates: #4718, elastic/elasticsearch#55760 This commit adds the voting config exclusions APIs to the high level client. Custom response builder types are required because the APIs return \n as the response, which the client will attempt to deserialize to a response object.
|
Do we have an issue on the elasticsearch repos tracking the empty new line? |
|
Yep, here's the Elasticsearch issue: elastic/elasticsearch#57639 |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 10, 2020
Relates: #4718, elastic/elasticsearch#55760 This commit adds the voting config exclusions APIs to the high level client. Custom response builder types are required because the APIs return \n as the response, which the client will attempt to deserialize to a response object.
github-actions bot
pushed a commit
that referenced
this pull request
Jun 10, 2020
Relates: #4718, elastic/elasticsearch#55760 This commit adds the voting config exclusions APIs to the high level client. Custom response builder types are required because the APIs return \n as the response, which the client will attempt to deserialize to a response object.
russcam
added a commit
that referenced
this pull request
Jun 10, 2020
Relates: #4718, elastic/elasticsearch#55760 This commit adds the voting config exclusions APIs to the high level client. Custom response builder types are required because the APIs return \n as the response, which the client will attempt to deserialize to a response object. Co-authored-by: Russ Cam <russ.cam@elastic.co>
russcam
added a commit
that referenced
this pull request
Jun 10, 2020
Relates: #4718, elastic/elasticsearch#55760 This commit adds the voting config exclusions APIs to the high level client. Custom response builder types are required because the APIs return \n as the response, which the client will attempt to deserialize to a response object. Co-authored-by: Russ Cam <russ.cam@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates: #4718, elastic/elasticsearch#55760
This commit adds the voting config exclusions APIs to the high level client.
Custom response builder types are required because the APIs return
\n as the response, which the client will attempt to deserialize to a
response object.