ST_EXTENT aggregation (#104659) #117451
Merged
ST_EXTENT aggregation (#104659) #117451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
needs:triage
GalLalouche
removed
needs:triage
…ticsearch/xpack/esql/planner/AggregateMapper.java
GalLalouche
added
>feature
:Analytics/Geo
craigtaverner
requested changes
Dec 12, 2024
...rc/main/java/org/elasticsearch/xpack/esql/expression/function/aggregate/SpatialStExtent.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/elasticsearch/xpack/esql/expression/function/aggregate/SpatialStExtent.java
Outdated
Show resolved
Hide resolved
...csearch/compute/aggregation/spatial/SpatialStExtentCartesianPointSourceValuesAggregator.java
Outdated
Show resolved
Hide resolved
...a/org/elasticsearch/compute/aggregation/spatial/SpatialStExtentCartesianShapeAggregator.java
Outdated
Show resolved
Hide resolved
...elasticsearch/compute/aggregation/spatial/SpatialStExtentGeoPointSourceValuesAggregator.java
Outdated
Show resolved
Hide resolved
...st/java/org/elasticsearch/xpack/esql/expression/function/aggregate/SpatialStExtentTests.java
Outdated
Show resolved
Hide resolved
...st/java/org/elasticsearch/xpack/esql/expression/function/aggregate/SpatialStExtentTests.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/expression/RectangleMatcher.java
Show resolved
Hide resolved
...ql/src/test/java/org/elasticsearch/xpack/esql/expression/WellKnownBinaryBytesRefMatcher.java
Show resolved
Hide resolved
| * Also note that the type converting function is removed when it does not actually convert the type, | ||
| * ensuring that ReferenceAttributes are not created for the same field, and the optimization can still work. | ||
| */ | ||
| public void testSpatialTypesAndStatsExtentUseDocValues() { |
There was a problem hiding this comment.
Perhaps a test that has both centroid and extent aggregations?
…rch into feature/st_extent
craigtaverner
approved these changes
Dec 12, 2024
💔 Backport failed
You can use sqren/backport to manually backport by running |
GalLalouche
added a commit
to GalLalouche/elasticsearch
that referenced
this pull request
Dec 17, 2024
This PR adds support for ST_EXTENT_AGG aggregation, i.e., computing a bounding box over a set of points/shapes (Cartesian or geo). Note the difference between this aggregation and the already implemented scalar function ST_EXTENT. This isn't a very efficient implementation, and future PRs will attempt to read these extents directly from the doc values. We currently always use longitude wrapping, i.e., we may wrap around the dateline for a smaller bounding box. Future PRs will let the user control this behavior. Fixes elastic#104659.
GalLalouche
added a commit
to GalLalouche/elasticsearch
that referenced
this pull request
Dec 17, 2024
This PR adds support for ST_EXTENT_AGG aggregation, i.e., computing a bounding box over a set of points/shapes (Cartesian or geo). Note the difference between this aggregation and the already implemented scalar function ST_EXTENT. This isn't a very efficient implementation, and future PRs will attempt to read these extents directly from the doc values. We currently always use longitude wrapping, i.e., we may wrap around the dateline for a smaller bounding box. Future PRs will let the user control this behavior. Fixes elastic#104659.
GalLalouche
added a commit
to GalLalouche/elasticsearch
that referenced
this pull request
Dec 17, 2024
This PR adds support for ST_EXTENT_AGG aggregation, i.e., computing a bounding box over a set of points/shapes (Cartesian or geo). Note the difference between this aggregation and the already implemented scalar function ST_EXTENT. This isn't a very efficient implementation, and future PRs will attempt to read these extents directly from the doc values. We currently always use longitude wrapping, i.e., we may wrap around the dateline for a smaller bounding box. Future PRs will let the user control this behavior. Fixes elastic#104659.
GalLalouche
added a commit
to GalLalouche/elasticsearch
that referenced
this pull request
Dec 17, 2024
This PR adds support for ST_EXTENT_AGG aggregation, i.e., computing a bounding box over a set of points/shapes (Cartesian or geo). Note the difference between this aggregation and the already implemented scalar function ST_EXTENT. This isn't a very efficient implementation, and future PRs will attempt to read these extents directly from the doc values. We currently always use longitude wrapping, i.e., we may wrap around the dateline for a smaller bounding box. Future PRs will let the user control this behavior. Fixes elastic#104659.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 17, 2024
This PR adds support for ST_EXTENT_AGG aggregation, i.e., computing a bounding box over a set of points/shapes (Cartesian or geo). Note the difference between this aggregation and the already implemented scalar function ST_EXTENT. This isn't a very efficient implementation, and future PRs will attempt to read these extents directly from the doc values. We currently always use longitude wrapping, i.e., we may wrap around the dateline for a smaller bounding box. Future PRs will let the user control this behavior. Fixes #104659.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
ST_EXTENTaggregation (Issue #104659)This PR adds support for
ST_EXTENTaggregation, i.e., computing a bounding box over a set of points/shapes (Cartesian or geo). (Note the difference between this aggregation and the already implemented *scalar *functionST_EXTENT).Fixes #104659