Skip to content

[Inference API] Add Jina AI API to do inference for Embedding and Rerank models #118652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 49 commits into from
Jan 8, 2025
Merged

[Inference API] Add Jina AI API to do inference for Embedding and Rerank models #118652

merged 49 commits into from
Jan 8, 2025

Conversation

JoanFM
Copy link
Contributor

@JoanFM JoanFM commented Dec 13, 2024

This is the code to add Jina AI as a plugin to do inference for embeddigns and reranking

@elasticsearchmachine elasticsearchmachine added external-contributor Pull request authored by a developer outside the Elasticsearch team v9.0.0 labels Dec 13, 2024
@davidkyle davidkyle self-assigned this Dec 13, 2024
@davidkyle davidkyle added >enhancement :ml Machine learning labels Dec 13, 2024
@JoanFM JoanFM marked this pull request as ready for review December 16, 2024 14:35
@elasticsearchmachine elasticsearchmachine added the Team:ML Meta label for the ML team label Dec 16, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@jonathan-buttner jonathan-buttner self-assigned this Dec 16, 2024
@JoanFM JoanFM mentioned this pull request Dec 16, 2024
Merged
timgrein
timgrein reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

@timgrein timgrein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! 👏

Excited to see JinaAI becoming another provider in Elastic's inference APIs. I gave your PR a first review pass (excluding tests for now) - I'll give it another review after these comments are addressed. Thanks!

@davidkyle
Copy link
Member

@elasticmachine test this please

@davidkyle
Copy link
Member

@elasticmachine test this please

@davidkyle
Copy link
Member

@elasticmachine test this please

@maxhniebergall
Copy link
Contributor

@elasticmachine test this please

@maxhniebergall
Copy link
Contributor

@elasticmachine test this please

@davidkyle davidkyle added the auto-backport Automatically create backport pull requests when merged label Jan 7, 2025
@davidkyle
Copy link
Member

@elasticmachine test this please

@davidkyle davidkyle enabled auto-merge (squash) January 7, 2025 18:06
@davidkyle
Copy link
Member

@elasticmachine test this please

@davidkyle davidkyle merged commit bf38719 into elastic:main Jan 8, 2025
17 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 118652

davidkyle pushed a commit to davidkyle/elasticsearch that referenced this pull request Jan 8, 2025
@davidkyle
[Inference API] Add Jina AI API to do inference for Embedding and Rer…
ec0338d 
…ank models (elastic#118652)

# Conflicts:
#	x-pack/plugin/inference/qa/inference-service-tests/src/javaRestTest/java/org/elasticsearch/xpack/inference/InferenceCrudIT.java
@davidkyle davidkyle mentioned this pull request Jan 8, 2025
Merged
elasticsearchmachine pushed a commit that referenced this pull request Jan 9, 2025
@davidkyle @jonathan-buttner
[Inference API] Add Jina AI API to do inference for Embedding and Rer…
0da2fab 
…ank models (#118652) (#119752)

# Conflicts:
#	x-pack/plugin/inference/qa/inference-service-tests/src/javaRestTest/java/org/elasticsearch/xpack/inference/InferenceCrudIT.java

Co-authored-by: Joan Fontanals <joan.fontanals.martinez@jina.ai>
Co-authored-by: Jonathan Buttner <jonathan.buttner@elastic.co>
@darnautov darnautov mentioned this pull request Jan 24, 2025
Merged
darnautov added a commit to elastic/kibana that referenced this pull request Jan 27, 2025
@darnautov @elasticmachine
[Inference] Add Jina AI icon (#208227)
44aa347 
## Summary

Add a provider icon for the Jina AI integration
elastic/elasticsearch#118652

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 27, 2025
@darnautov @elasticmachine
[Inference] Add Jina AI icon (elastic#208227)
86254a9 
## Summary

Add a provider icon for the Jina AI integration
elastic/elasticsearch#118652

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 44aa347)
kibanamachine added a commit to elastic/kibana that referenced this pull request Jan 27, 2025
@kibanamachine @darnautov
[8.x] [Inference] Add Jina AI icon (#208227) (#208333)
28ec16b 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Inference] Add Jina AI icon
(#208227)](#208227)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dima
Arnautov","email":"dmitrii.arnautov@elastic.co"},"sourceCommit":{"committedDate":"2025-01-27T10:10:56Z","message":"[Inference]
Add Jina AI icon (#208227)\n\n## Summary\r\n\r\nAdd a provider icon for
the Jina AI
integration\r\nhttps://github.com/elastic/elasticsearch/pull/118652\r\n\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"44aa347102f98f60d5b3c1523a3318f301ffc3c0","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","v8.18.0"],"title":"[Inference]
Add Jina AI icon
","number":208227,"url":"https://github.com/elastic/kibana/pull/208227","mergeCommit":{"message":"[Inference]
Add Jina AI icon (#208227)\n\n## Summary\r\n\r\nAdd a provider icon for
the Jina AI
integration\r\nhttps://github.com/elastic/elasticsearch/pull/118652\r\n\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"44aa347102f98f60d5b3c1523a3318f301ffc3c0"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208227","number":208227,"mergeCommit":{"message":"[Inference]
Add Jina AI icon (#208227)\n\n## Summary\r\n\r\nAdd a provider icon for
the Jina AI
integration\r\nhttps://github.com/elastic/elasticsearch/pull/118652\r\n\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"44aa347102f98f60d5b3c1523a3318f301ffc3c0"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Jan 27, 2025
@darnautov @elasticmachine @JoseLuisGJ
[Inference] Add Jina AI icon (elastic#208227)
8b2e07b 
## Summary

Add a provider icon for the Jina AI integration
elastic/elasticsearch#118652

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timgrein timgrein timgrein approved these changes

@jonathan-buttner jonathan-buttner jonathan-buttner approved these changes

@davidkyle davidkyle Awaiting requested review from davidkyle

Assignees

@davidkyle davidkyle

@jonathan-buttner jonathan-buttner

Labels
auto-backport Automatically create backport pull requests when merged backport pending >enhancement external-contributor Pull request authored by a developer outside the Elasticsearch team :ml Machine learning Team:ML Meta label for the ML team v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JoanFM @elasticsearchmachine @davidkyle @maxhniebergall @timgrein @jonathan-buttner