Skip to content

[ES|QL] Support subset of metrics in agg metric double #121805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

limotova
Copy link
Contributor

@limotova limotova commented Feb 5, 2025

This commit adds adds support for mappings containing only a subset of
metrics in aggregate metric double (i.e. only sum and value_count, or
just max, etc) as well as tests for grouped aggregations on aggregate
metric double.

@limotova limotova force-pushed the agg-metric-double-metric-subset-and-grouping branch 2 times, most recently from 59ea292 to 27ac168 Compare February 5, 2025 19:48
@limotova limotova force-pushed the agg-metric-double-metric-subset-and-grouping branch from 27ac168 to ff77473 Compare February 6, 2025 00:17
@limotova limotova changed the title [ES|QL] Support set of submetrics in agg metric double [ES|QL] Support partial subset of metrics in aggregate metric double Feb 6, 2025
@limotova limotova changed the title [ES|QL] Support partial subset of metrics in aggregate metric double [ES|QL] Support subset of metrics in agg metric double Feb 6, 2025
@limotova limotova requested review from martijnvg and dnhatn February 6, 2025 02:04
Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Larisa!

@limotova limotova added >enhancement auto-backport Automatically create backport pull requests when merged :StorageEngine/TSDB You know, for Metrics :Analytics/ES|QL AKA ESQL and removed auto-backport Automatically create backport pull requests when merged labels Feb 6, 2025
@limotova limotova marked this pull request as ready for review February 6, 2025 04:18
@elasticsearchmachine elasticsearchmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:StorageEngine labels Feb 6, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @limotova, I've created a changelog YAML for you.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@limotova limotova added backport auto-backport Automatically create backport pull requests when merged v8.19.0 and removed backport labels Feb 6, 2025
@limotova limotova merged commit 3abc852 into elastic:main Feb 7, 2025
17 checks passed
@limotova limotova deleted the agg-metric-double-metric-subset-and-grouping branch February 7, 2025 19:29
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 121805

elasticsearchmachine pushed a commit that referenced this pull request Feb 7, 2025
…2087)

This commit adds adds support for mappings containing only a subset of
metrics in aggregate metric double (i.e. only sum and value_count, or
just max, etc) as well as tests for grouped aggregations on aggregate
metric double.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged >enhancement :StorageEngine/TSDB You know, for Metrics Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:StorageEngine v8.19.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants