feat: VoyageAI integration #122134

fzowl · 2025-02-09T14:07:52Z

VoyageAI embeddings and rerank model integration through the API (https://docs.voyageai.com/reference/embeddings-api and https://docs.voyageai.com/reference/reranker-api)

- embeddings works, tested - initial rerank code What's missing: - unit and integration tests - rerank request/response mapping and verification

- embeddings works, tested - rerank works, tested (https://www.elastic.co/search-labs/blog/elasticsearch-cohere-rerank) What's missing: - unit and integration tests

Moving dimensions to ServiceSettings

feat: VoyageAI integration

elasticsearchmachine · 2025-02-09T14:08:16Z

@fzowl please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

fzowl · 2025-02-09T14:21:07Z

@davidkyle, can you please take a look? (sorry, this PR became huge with all the integrations and the tests)

elasticsearchmachine · 2025-02-10T11:52:14Z

Pinging @elastic/ml-core (Team:ML)

davidkyle · 2025-02-10T11:52:43Z

@elasticmachine test this please

jonathan-buttner · 2025-02-19T13:26:26Z

@elasticmachine test this please

jonathan-buttner · 2025-02-19T14:24:18Z

Hmm I think spotless is complaining, running spotless like this might help:

./gradlew :x-pack:plugin:core:spotlessApply :x-pack:plugin:core:precommit :x-pack:plugin:ml:spotlessApply :x-pack:plugin:ml:precommit :x-pack:plugin:inference:spotlessApply :x-pack:plugin:inference:precommit :x-pack:plugin:ml:qa:native-multi-node-tests:precommit :server:precommit

fzowl · 2025-02-19T22:04:32Z

@jonathan-buttner Thanks! This solved the problem for me: ./gradlew :x-pack:plugin:inference:qa:inference-service-tests:spotlessApply

jonathan-buttner · 2025-02-20T13:13:59Z

@elasticmachine test this please

fzowl · 2025-02-20T14:32:40Z

@jonathan-buttner can you please help me here? I found that i can reproduce the test with ./gradlew ":rest-api-spec:yamlRestCompatTest" --tests "org.elasticsearch.test.rest.ClientYamlTestSuiteIT" -Dtests.method="test {yaml=indices.create/21_synthetic_source_stored/index param - field ordering}" -Dtests.seed=29856D0D59D74338 -Dtests.locale=csw -Dtests.timezone=US/Pacific -Druntime.java=23 and i could reproduce....but honestly, i don't know why it fails.

Can you please point me to the right direction to resolve this? Also, I gave you write permission so please feel free to make any adjustment required. Thank you!

jonathan-buttner · 2025-02-20T14:34:23Z

@elasticmachine merge upstream

jonathan-buttner · 2025-02-20T14:35:24Z

@jonathan-buttner can you please help me here?

Yeah that's probably a flaky test. Try merging in main and I'll run the tests again.

jonathan-buttner · 2025-02-20T14:35:57Z

Also, I gave you write permission so please feel free to make any adjustment required. Thank you!

Oh just saw that, thanks! Let me see if I can merge upstream for you

jonathan-buttner · 2025-02-20T15:11:32Z

@fzowl hmm, I'm having trouble pushing directly to the upstream. Normally I can gh pr checkout 122134 and then push directly but doesn't seem like that's working:

❯ git push
fatal: The upstream branch of your current branch does not match
the name of your current branch.  To push to the upstream branch
on the remote, use

    git push upstream HEAD:refs/pull/122134/head

To push to the branch of the same name on the remote, use

    git push upstream HEAD

To avoid automatically configuring an upstream branch when its name
won't match the local branch, see option 'simple' of branch.autoSetupMerge
in 'git help config'.

I merged main, and had to resolve the conflicts in the TransportVersions file. Looks like the number changed so we needed to bump the public static final TransportVersion VOYAGE_AI_INTEGRATION_ADDED_BACKPORT_8_X = def(8_841_0_05); note the 8_841_0_05 instead of 8_840_0_05.

Could you try merging upstream?

…i-main

jonathan-buttner · 2025-02-20T15:37:27Z

Never mind, I think I was able to do it!

jonathan-buttner · 2025-02-20T15:37:57Z

@elasticmachine test this please

fzowl · 2025-02-20T16:20:53Z

I merged main, and had to resolve the conflicts in the TransportVersions file. Looks like the number changed so we needed to bump the public static final TransportVersion VOYAGE_AI_INTEGRATION_ADDED_BACKPORT_8_X = def(8_841_0_05); note the 8_841_0_05 instead of 8_840_0_05.

Yeah, i noticed that a new minor version is created very frequently (for every merged PR?), that's why i wanted to modify TransportVersions right before you merge my PR: #122134

jonathan-buttner · 2025-02-20T18:07:53Z

@elasticmachine test this please

jonathan-buttner · 2025-02-20T19:22:35Z

@elasticmachine test this please

fzowl · 2025-02-20T20:55:41Z

@jonathan-buttner This looks good now!

fzowl · 2025-02-20T21:14:59Z

@jonathan-buttner Thank you very much for your help and support!

jonathan-buttner · 2025-02-20T22:34:35Z

Thanks for all the work to get this implemented! Glad I could help.

* VoyageAI embeddings and rerank: - embeddings works, tested - initial rerank code What's missing: - unit and integration tests - rerank request/response mapping and verification * VoyageAI embeddings and rerank: - embeddings works, tested - rerank works, tested (https://www.elastic.co/search-labs/blog/elasticsearch-cohere-rerank) What's missing: - unit and integration tests * VoyageAI embeddings and rerank: - embeddings works, tested - rerank works, tested (https://www.elastic.co/search-labs/blog/elasticsearch-cohere-rerank) What's missing: - unit and integration tests * VoyageAI embeddings and rerank: - embeddings works, tested - rerank works, tested (https://www.elastic.co/search-labs/blog/elasticsearch-cohere-rerank) What's missing: - unit and integration tests * Adding initial tests Moving dimensions to ServiceSettings * Correcting the TransportVersions.java * Correcting due to comments * Adding BIT support * Initial tests * More tests * More tests/corrections * Removing warnings * Further tests * Transport version correction * Adding changelog and correcting TransportVersions * Spotless tests * Changes due to the comments * Changes due to the comments * Correcting QA tests * Correcting QA tests --------- Co-authored-by: Jonathan Buttner <jonathan.buttner@elastic.co> Co-authored-by: Jonathan Buttner <56361221+jonathan-buttner@users.noreply.github.com>

jonathan-buttner · 2025-02-28T21:58:05Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Questions ?

Please refer to the Backport tool documentation

* VoyageAI embeddings and rerank: - embeddings works, tested - initial rerank code What's missing: - unit and integration tests - rerank request/response mapping and verification * VoyageAI embeddings and rerank: - embeddings works, tested - rerank works, tested (https://www.elastic.co/search-labs/blog/elasticsearch-cohere-rerank) What's missing: - unit and integration tests * VoyageAI embeddings and rerank: - embeddings works, tested - rerank works, tested (https://www.elastic.co/search-labs/blog/elasticsearch-cohere-rerank) What's missing: - unit and integration tests * VoyageAI embeddings and rerank: - embeddings works, tested - rerank works, tested (https://www.elastic.co/search-labs/blog/elasticsearch-cohere-rerank) What's missing: - unit and integration tests * Adding initial tests Moving dimensions to ServiceSettings * Correcting the TransportVersions.java * Correcting due to comments * Adding BIT support * Initial tests * More tests * More tests/corrections * Removing warnings * Further tests * Transport version correction * Adding changelog and correcting TransportVersions * Spotless tests * Changes due to the comments * Changes due to the comments * Correcting QA tests * Correcting QA tests --------- Co-authored-by: Jonathan Buttner <jonathan.buttner@elastic.co> Co-authored-by: Jonathan Buttner <56361221+jonathan-buttner@users.noreply.github.com> (cherry picked from commit 521f855) # Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/results/TextEmbeddingResultsTests.java

* feat: VoyageAI integration (#122134) * VoyageAI embeddings and rerank: - embeddings works, tested - initial rerank code What's missing: - unit and integration tests - rerank request/response mapping and verification * VoyageAI embeddings and rerank: - embeddings works, tested - rerank works, tested (https://www.elastic.co/search-labs/blog/elasticsearch-cohere-rerank) What's missing: - unit and integration tests * VoyageAI embeddings and rerank: - embeddings works, tested - rerank works, tested (https://www.elastic.co/search-labs/blog/elasticsearch-cohere-rerank) What's missing: - unit and integration tests * VoyageAI embeddings and rerank: - embeddings works, tested - rerank works, tested (https://www.elastic.co/search-labs/blog/elasticsearch-cohere-rerank) What's missing: - unit and integration tests * Adding initial tests Moving dimensions to ServiceSettings * Correcting the TransportVersions.java * Correcting due to comments * Adding BIT support * Initial tests * More tests * More tests/corrections * Removing warnings * Further tests * Transport version correction * Adding changelog and correcting TransportVersions * Spotless tests * Changes due to the comments * Changes due to the comments * Correcting QA tests * Correcting QA tests --------- Co-authored-by: Jonathan Buttner <jonathan.buttner@elastic.co> Co-authored-by: Jonathan Buttner <56361221+jonathan-buttner@users.noreply.github.com> (cherry picked from commit 521f855) # Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/results/TextEmbeddingResultsTests.java * Using correct transport version and fixing errors * Fixing errors and test failures --------- Co-authored-by: fzowl <160063452+fzowl@users.noreply.github.com>

fzowl and others added 15 commits February 5, 2025 17:09

VoyageAI embeddings and rerank:

0535410

- embeddings works, tested - initial rerank code What's missing: - unit and integration tests - rerank request/response mapping and verification

VoyageAI embeddings and rerank:

07c39a0

- embeddings works, tested - rerank works, tested (https://www.elastic.co/search-labs/blog/elasticsearch-cohere-rerank) What's missing: - unit and integration tests

VoyageAI embeddings and rerank:

91dee7f

- embeddings works, tested - rerank works, tested (https://www.elastic.co/search-labs/blog/elasticsearch-cohere-rerank) What's missing: - unit and integration tests

VoyageAI embeddings and rerank:

6f11414

- embeddings works, tested - rerank works, tested (https://www.elastic.co/search-labs/blog/elasticsearch-cohere-rerank) What's missing: - unit and integration tests

Adding initial tests

050d5b2

Moving dimensions to ServiceSettings

Correcting the TransportVersions.java

b94bc5f

Correcting due to comments

be1e9cf

Adding BIT support

71dfdc8

Initial tests

8f6e03b

More tests

d41538a

More tests/corrections

3f1a75a

Removing warnings

a89fdf1

Further tests

b7cb871

Transport version correction

b9681af

Merge pull request #2 from voyage-ai/voyageai

bcca709

feat: VoyageAI integration

elasticsearchmachine added needs:triage Requires assignment of a team area label v9.1.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Feb 9, 2025

Adding changelog and correcting TransportVersions

c211583

davidkyle self-assigned this Feb 10, 2025

davidkyle added :ml Machine learning v8.19.0 and removed needs:triage Requires assignment of a team area label labels Feb 10, 2025

elasticsearchmachine added the Team:ML Meta label for the ML team label Feb 10, 2025

davidkyle added the >enhancement label Feb 10, 2025

Merge branch 'main' into main

a14ea32

Correcting QA tests

1ebe1a4

Merge branch 'main' of github.com:elastic/elasticsearch into voyage-a…

8796053

…i-main

Merge branch 'main' into main

0a5b7c0

fzowl added 2 commits February 20, 2025 17:21

Merge branch 'main' into main

29fd189

Merge branch 'main' into main

baf9e3a

Merge branch 'main' into main

2a27c1d

jonathan-buttner merged commit 521f855 into elastic:main Feb 20, 2025
18 checks passed

jonathan-buttner mentioned this pull request Feb 28, 2025

[8.x] feat: VoyageAI integration (#122134) #123768

Merged

davidkyle mentioned this pull request Mar 28, 2025

[ML] Add Icon for Voyage AI integration elastic/kibana#216309

Closed

feat: VoyageAI integration #122134

feat: VoyageAI integration #122134

Uh oh!

Conversation

fzowl commented Feb 9, 2025

Uh oh!

elasticsearchmachine commented Feb 9, 2025

Uh oh!

fzowl commented Feb 9, 2025

Uh oh!

elasticsearchmachine commented Feb 10, 2025

Uh oh!

davidkyle commented Feb 10, 2025

Uh oh!

jonathan-buttner commented Feb 19, 2025

Uh oh!

jonathan-buttner commented Feb 19, 2025

Uh oh!

fzowl commented Feb 19, 2025

Uh oh!

jonathan-buttner commented Feb 20, 2025

Uh oh!

fzowl commented Feb 20, 2025

Uh oh!

jonathan-buttner commented Feb 20, 2025

Uh oh!

jonathan-buttner commented Feb 20, 2025

Uh oh!

jonathan-buttner commented Feb 20, 2025

Uh oh!

jonathan-buttner commented Feb 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonathan-buttner commented Feb 20, 2025

Uh oh!

jonathan-buttner commented Feb 20, 2025

Uh oh!

fzowl commented Feb 20, 2025

Uh oh!

jonathan-buttner commented Feb 20, 2025

Uh oh!

jonathan-buttner commented Feb 20, 2025

Uh oh!

fzowl commented Feb 20, 2025

Uh oh!

Uh oh!

fzowl commented Feb 20, 2025

Uh oh!

jonathan-buttner commented Feb 20, 2025

Uh oh!

jonathan-buttner commented Feb 28, 2025

💚 All backports created successfully

Questions ?

Uh oh!

Uh oh!

jonathan-buttner commented Feb 20, 2025 •

edited

Loading