Avoid serializing empty _source fields in mappings. #122606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
added
:StorageEngine/Mapping
|
Hi @martijnvg, I've created a changelog YAML for you. |
martijnvg
added
v9.0.0
v8.18.1
v9.0.1
auto-backport
elasticsearchmachine
added
the
serverless-linked
martijnvg
commented
Mar 3, 2025
| (b, n, v) -> b.field(n, v.toString().toLowerCase(Locale.ROOT)), | ||
| v -> v.toString().toLowerCase(Locale.ROOT) | ||
| ).setMergeValidator((previous, current, conflicts) -> (previous == current) || current != Mode.STORED) | ||
| this.mode = new Parameter<>("mode", true, () -> null, (n, c, o) -> Mode.valueOf(o.toString().toUpperCase(Locale.ROOT)), m -> { |
There was a problem hiding this comment.
This is the actual fix. The initializer set the mode only based on whether enabled parameter was specified and didn't check the serializeMode field.
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
martijnvg
commented
Mar 3, 2025
| .feature(FeatureFlag.TIME_SERIES_MODE) | ||
| .feature(FeatureFlag.FAILURE_STORE_ENABLED); | ||
|
|
||
| if (oldVersion.before(Version.fromString("9.1.0"))) { |
There was a problem hiding this comment.
I plan to backport this all the way to 8.18 branch, which means when back ported this version will be updated. And I think after 8.19 has been removed this can be removed from main.
lkts
approved these changes
Mar 3, 2025
💔 Backport failed
You can use sqren/backport to manually backport by running |
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Mar 6, 2025
Backporting elastic#122606 to 8.18 branch.
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Mar 6, 2025
Backporting elastic#122606 to 8.x branch.
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Mar 6, 2025
Backporting elastic#122606 to 9.0 branch.
martijnvg
added a commit
that referenced
this pull request
Mar 7, 2025
Backporting #122606 to 9.0 branch.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 7, 2025
* [8.x] Avoid serializing empty _source fields in mappings. Backporting #122606 to 8.x branch. * Fix initialize builder for merging * iter
martijnvg
added a commit
that referenced
this pull request
Mar 8, 2025
Backporting #122606 to 8.18 branch.
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Mar 11, 2025
costin
pushed a commit
to costin/elasticsearch
that referenced
this pull request
Mar 15, 2025
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Mar 18, 2025
Remove `-da:org.elasticsearch.index.mapper.DocumentMapper` and `-da:org.elasticsearch.index.mapper.MapperService` from cluster setup. Given that elastic#122606 is now backported to the 8.18 branch.
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Mar 18, 2025
Update `-da:org.elasticsearch.index.mapper.DocumentMapper` and `-da:org.elasticsearch.index.mapper.MapperService` from cluster setup. Given that elastic#122606 is now backported to the 8.18 branch.
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Mar 19, 2025
Backporting elastic#125074 to 9.0 branch. Remove `-da:org.elasticsearch.index.mapper.DocumentMapper` and `-da:org.elasticsearch.index.mapper.MapperService` from mixed cluster/bwc cluster setups. Given that elastic#122606 is now backported to the 8.18 branch.
This was referenced Mar 19, 2025
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Mar 19, 2025
Backporting elastic#125074 to 8.x branch. Remove `-da:org.elasticsearch.index.mapper.DocumentMapper` and `-da:org.elasticsearch.index.mapper.MapperService` from mixed cluster/bwc cluster setups. Given that elastic#122606 is now backported to the 8.18 branch.
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Mar 21, 2025
…stic#125074) Remove `-da:org.elasticsearch.index.mapper.DocumentMapper` and `-da:org.elasticsearch.index.mapper.MapperService` from mixed cluster/bwc cluster setups. Given that elastic#122606 is now backported to the 8.18 branch.
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
…stic#125074) Remove `-da:org.elasticsearch.index.mapper.DocumentMapper` and `-da:org.elasticsearch.index.mapper.MapperService` from mixed cluster/bwc cluster setups. Given that elastic#122606 is now backported to the 8.18 branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.