Add bit vector support to semantic text #123187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikep86
added
>enhancement
auto-backport
|
Hi @Mikep86, I've created a changelog YAML for you. |
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
|
Pinging @elastic/search-eng (Team:SearchOrg) |
|
Pinging @elastic/search-relevance (Team:Search - Relevance) |
|
@elasticmachine update branch |
Mikep86
commented
Feb 25, 2025
server/src/main/java/org/elasticsearch/inference/MinimalServiceSettings.java
Outdated
Show resolved
Hide resolved
jimczi
reviewed
Feb 26, 2025
server/src/main/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapper.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/inference/MinimalServiceSettings.java
Outdated
Show resolved
Hide resolved
Mikep86
commented
Feb 26, 2025
...src/main/java/org/elasticsearch/xpack/inference/mock/TestDenseInferenceServiceExtension.java
Show resolved
Hide resolved
jimczi
approved these changes
Feb 27, 2025
...src/main/java/org/elasticsearch/xpack/inference/mock/TestDenseInferenceServiceExtension.java
Show resolved
Hide resolved
|
@elasticmachine update branch |
|
@elasticmachine update branch |
kderusso
approved these changes
Mar 3, 2025
| @@ -646,7 +644,7 @@ private static class StaticModel extends TestModel { | |||
| } | |||
|
|
|||
| public static StaticModel createRandomInstance() { | |||
| TestModel testModel = randomModel(randomFrom(TaskType.TEXT_EMBEDDING, TaskType.SPARSE_EMBEDDING)); | |||
| TestModel testModel = TestModel.createRandomInstance(); | |||
💚 Backport successful
|
Mikep86
added a commit
to Mikep86/elasticsearch
that referenced
this pull request
Mar 7, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 7, 2025
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds bit vector support to the
semantic_textfield mapping andsemanticquery. The changes to production code are minimal, nearly all of the changes are to test code to ensure that we have good coverage with inference services that generate bit vectors.