Use logs dir as working directory #124966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the unexpected case that Elasticsearch dies due to a segfault or other similar native issue, a core dump is useful in diagnosing the problem. Yet core dumps are written to the working directory, which is read-only for most installations of Elasticsearch. This commit changes the working directory to the logs dir which should always be writeable.
rjernst
added
>enhancement
:Core/Infra/CLI
|
Hi @rjernst, I've created a changelog YAML for you. |
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
elasticsearchmachine
added
the
serverless-linked
mosche
reviewed
Apr 9, 2025
...t/groovy/org/elasticsearch/gradle/internal/test/rest/LegacyYamlRestTestPluginFuncTest.groovy
Show resolved
Hide resolved
|
|
||
| ReplacementKey heapDumpPathSub; | ||
| if (version.before("8.19.0") && version.onOrAfter("6.3.0")) { | ||
| heapDumpPathSub = new ReplacementKey("-XX:HeapDumpPath=data", ""); |
There was a problem hiding this comment.
I think using "" as fallback is wrong here, every string will contain this fallback leading to unexpected and clearly wrong results when replacing... should this be null or the fallback optional to make the intend clearer in this case?
There was a problem hiding this comment.
I like your suggestion. I pushed 43db0f2
|
|
||
| ReplacementKey heapDumpPathSub; | ||
| if (version.before("8.19.0") && version.onOrAfter("6.3.0")) { | ||
| heapDumpPathSub = new ReplacementKey("-XX:HeapDumpPath=data", ""); |
There was a problem hiding this comment.
Same as mentioned previously, the "" fallback looks troublesome. I think that needs special handling (and should be more explicit)
💔 Backport failed
You can use sqren/backport to manually backport by running |
|
@rjernst With this change I am seeing a difference in behavior. Previously when invoking elasticsearch with What is the expected behavior for ES when Here is a stack trace that seems to point to the recent change in ES: |
1 task
This was referenced Apr 9, 2025
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Apr 9, 2025
With the change to using the logs dir as the working dir of the Elasticsearch process we need to ensure the logs dir exists within the CLI instead of later during startup. relates elastic#124966
rjernst
added a commit
that referenced
this pull request
Apr 17, 2025
With the change to using the logs dir as the working dir of the Elasticsearch process we need to ensure the logs dir exists within the CLI instead of later during startup. relates #124966
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Jul 2, 2025
In the unexpected case that Elasticsearch dies due to a segfault or other similar native issue, a core dump is useful in diagnosing the problem. Yet core dumps are written to the working directory, which is read-only for most installations of Elasticsearch. This commit changes the working directory to the logs dir which should always be writeable.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Jul 2, 2025
With the change to using the logs dir as the working dir of the Elasticsearch process we need to ensure the logs dir exists within the CLI instead of later during startup. relates elastic#124966
shainaraskas
added
the
docs-missing-applies-tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the unexpected case that Elasticsearch dies due to a segfault or other similar native issue, a core dump is useful in diagnosing the problem. Yet core dumps are written to the working directory, which is read-only for most installations of Elasticsearch. This commit changes the working directory to the logs dir which should always be writeable.