Disable logging in ClusterFormationFailureHelper on shutdown.
#125244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifies Coordinator to enable logging in ClusterFormationFailureHelper when started and disables logging in ClusterFormationFailureHelper when stopped. The warning scheduler handling and invariant check in the Coordinator are left as is, with the logging boolean set independently, eliminating the need to hold the mutex in doStop() when Coordinator.stop() is called when the Node is shutdown. Closes elastic#105559.
JeremyDahlgren
commented
Mar 19, 2025
Comment on lines
+97
to
+98
| public void setLoggingEnabled(boolean enabled) { | ||
| this.loggingEnabled = enabled; |
There was a problem hiding this comment.
Initially it seemed that a
synchronized(mutex) {
clusterFormationFailureHelper.stop();
}
block in Coordinator::doStop() would be sufficient, but besides needing to hold the lock when the Node is being shut down, it seems a race condition could exist where the failure helper is stopped on shutdown but another thread immediately calls becomeCandidate() and starts it back up?
Also if calls to ClusterFormationFailureHelper start() and stop() were not synchronized it looks like there is the potential for a NullPointerException in start() if the warningScheduler is set to null between the assignment of a new WarningScheduler instance and the next line that calls scheduleNextWarning (Intellij warns about this):
public void start() {
assert warningScheduler == null;
warningScheduler = new WarningScheduler();
warningScheduler.scheduleNextWarning();
}
public void stop() {
warningScheduler = null;
}
JeremyDahlgren
added
Team:Distributed Coordination
|
Hi @JeremyDahlgren, I've created a changelog YAML for you. |
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
afoucret
pushed a commit
to afoucret/elasticsearch
that referenced
this pull request
Mar 21, 2025
…c#125244) Modifies Coordinator to enable logging in ClusterFormationFailureHelper when started and disables logging in ClusterFormationFailureHelper when stopped. The warning scheduler handling and invariant check in the Coordinator are left as is, with the logging boolean set independently, eliminating the need to hold the mutex in doStop() when Coordinator.stop() is called when the Node is shutdown. Closes elastic#105559. * Update docs/changelog/125244.yaml
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Mar 21, 2025
…c#125244) Modifies Coordinator to enable logging in ClusterFormationFailureHelper when started and disables logging in ClusterFormationFailureHelper when stopped. The warning scheduler handling and invariant check in the Coordinator are left as is, with the logging boolean set independently, eliminating the need to hold the mutex in doStop() when Coordinator.stop() is called when the Node is shutdown. Closes elastic#105559. * Update docs/changelog/125244.yaml
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
…c#125244) Modifies Coordinator to enable logging in ClusterFormationFailureHelper when started and disables logging in ClusterFormationFailureHelper when stopped. The warning scheduler handling and invariant check in the Coordinator are left as is, with the logging boolean set independently, eliminating the need to hold the mutex in doStop() when Coordinator.stop() is called when the Node is shutdown. Closes elastic#105559. * Update docs/changelog/125244.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies
Coordinatorto enable logging inClusterFormationFailureHelperwhen started and disables logging inClusterFormationFailureHelperwhen stopped. The warning scheduler handling and invariant check in theCoordinatorare left as is, with the logging boolean set independently, eliminating the need to hold themutexindoStop()whenCoordinator.stop()is called when theNodeis shutdown.Closes #105559.