Skip to content

[ES|QL] Infer the score mode to use from the Lucene collector #125930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 1, 2025
Merged

[ES|QL] Infer the score mode to use from the Lucene collector #125930

merged 10 commits into from
Apr 1, 2025

Conversation

jimczi
Copy link
Contributor

@jimczi jimczi commented Mar 31, 2025

This change uses the Lucene collector to infer which score mode to use when the topN collector is used.

@jimczi
[ES|QL] Infer the score mode to use from the Lucene collector
7ff51d6 
This change uses the Lucene collector to infer which score mode to use
when the topN collector is used.
@jimczi jimczi requested review from carlosdelest and ioanatia March 31, 2025 10:42
@elasticsearchmachine elasticsearchmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch labels Mar 31, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @jimczi, I've created a changelog YAML for you.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

carlosdelest
carlosdelest approved these changes Mar 31, 2025
View reviewed changes
Copy link
Member

@carlosdelest carlosdelest left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@jimczi jimczi added the auto-backport Automatically create backport pull requests when merged label Mar 31, 2025
@jimczi jimczi merged commit 42b7b78 into elastic:main Apr 1, 2025
17 checks passed
@jimczi jimczi deleted the esql_score_mode branch April 1, 2025 10:52
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 125930

@jimczi jimczi mentioned this pull request Apr 1, 2025
Merged
elasticsearchmachine pushed a commit that referenced this pull request Apr 3, 2025
@jimczi
[8.x] Infer the score mode to use from the Lucene collector (#125930) (…
8ecac02 
…#126032)

* [ES|QL] Infer the score mode to use from the Lucene collector (#125930)

This change uses the Lucene collector to infer which score mode to use
when the topN collector is used.

* fix typo

* fix tests
@ioanatia ioanatia mentioned this pull request Jul 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosdelest carlosdelest carlosdelest approved these changes

@ioanatia ioanatia ioanatia approved these changes

Assignees
No one assigned
Labels
:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged >enhancement :Search Relevance/Search Catch all for Search Relevance Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v8.19.0 v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jimczi @elasticsearchmachine @carlosdelest @ioanatia