Skip to content

Fix NPE for missing Content Type header in OIDC Authenticator #126191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2025

Conversation

richard-dennehy
Copy link
Contributor

Fixes a NullPointerException that may be thrown when the OIDC provider token response Content Type header is missing. This is likely because of a misconfiguration on the OIDC provider that we need to handle.

@richard-dennehy richard-dennehy added >bug :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) auto-backport Automatically create backport pull requests when merged v8.18.1 v8.19.0 v9.0.1 v9.1.0 v8.17.5 labels Apr 3, 2025
@richard-dennehy richard-dennehy requested a review from jfreden April 3, 2025 09:26
@elasticsearchmachine elasticsearchmachine added the Team:Security Meta label for security team label Apr 3, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@elasticsearchmachine
Copy link
Collaborator

Hi @richard-dennehy, I've created a changelog YAML for you.

@richard-dennehy richard-dennehy force-pushed the null-content-type-fix branch from b87a509 to d147a80 Compare April 3, 2025 09:48
Copy link
Contributor

@jfreden jfreden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.18
8.x
9.0
8.17

richard-dennehy added a commit to richard-dennehy/elasticsearch that referenced this pull request Apr 3, 2025
…c#126191)

* Fix NPE for missing Content Type header in OIDC Authenticator

* Update docs/changelog/126191.yaml
richard-dennehy added a commit to richard-dennehy/elasticsearch that referenced this pull request Apr 3, 2025
…c#126191)

* Fix NPE for missing Content Type header in OIDC Authenticator

* Update docs/changelog/126191.yaml
@richard-dennehy richard-dennehy deleted the null-content-type-fix branch April 3, 2025 11:42
richard-dennehy added a commit to richard-dennehy/elasticsearch that referenced this pull request Apr 3, 2025
…c#126191)

* Fix NPE for missing Content Type header in OIDC Authenticator

* Update docs/changelog/126191.yaml
elasticsearchmachine pushed a commit that referenced this pull request Apr 3, 2025
… (#126205)

* Fix NPE for missing Content Type header in OIDC Authenticator

* Update docs/changelog/126191.yaml
elasticsearchmachine pushed a commit that referenced this pull request Apr 3, 2025
… (#126203)

* Fix NPE for missing Content Type header in OIDC Authenticator

* Update docs/changelog/126191.yaml
elasticsearchmachine pushed a commit that referenced this pull request Apr 3, 2025
… (#126206)

* Fix NPE for missing Content Type header in OIDC Authenticator

* Update docs/changelog/126191.yaml
elasticsearchmachine pushed a commit that referenced this pull request Apr 3, 2025
… (#126202)

* Fix NPE for missing Content Type header in OIDC Authenticator

* Update docs/changelog/126191.yaml
andreidan pushed a commit to andreidan/elasticsearch that referenced this pull request Apr 9, 2025
…c#126191)

* Fix NPE for missing Content Type header in OIDC Authenticator

* Update docs/changelog/126191.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged >bug :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) Team:Security Meta label for security team v8.17.5 v8.18.1 v8.19.0 v9.0.1 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants