Skip to content

ESQL: Disable a bugged commit #127199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2025
Merged

ESQL: Disable a bugged commit #127199

merged 2 commits into from
Apr 23, 2025

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Apr 22, 2025

The PR #126641 has a bug with !=.

Closes #127197

The PR elastic#126641 has a bug with `!=`.
@nik9000 nik9000 added >bug auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Analytics/ES|QL AKA ESQL v9.1.0 labels Apr 22, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Apr 22, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine
Copy link
Collaborator

Hi @nik9000, I've created a changelog YAML for you.

Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nik9000
Copy link
Member Author

nik9000 commented Apr 23, 2025

It looks like one of the tests is failing sometimes. i'm going to squash and merge this anyway to get the disable and let the robot mute the test.

@nik9000 nik9000 merged commit ef0a177 into elastic:main Apr 23, 2025
16 of 17 checks passed
@nik9000 nik9000 deleted the disable_126641 branch April 23, 2025 11:37
nik9000 added a commit to nik9000/elasticsearch that referenced this pull request Apr 23, 2025
nik9000 added a commit that referenced this pull request Apr 23, 2025
nik9000 added a commit to nik9000/elasticsearch that referenced this pull request May 19, 2025
nik9000 added a commit to nik9000/elasticsearch that referenced this pull request May 19, 2025
@nik9000
Copy link
Member Author

nik9000 commented May 19, 2025

Backported by #128156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESQL: In main <text_field> != will incorrectly match long strings
4 participants