Add emit time to hash aggregation status #127988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>enhancement
auto-backport
|
Hi @dnhatn, I've created a changelog YAML for you. |
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
LGTM. Not signed in on this laptop but feel free to merge when you want.
…On Fri, May 9, 2025 at 1:15 PM elasticsearchmachine < ***@***.***> wrote:
*elasticsearchmachine* left a comment (elastic/elasticsearch#127988)
<#127988 (comment)>
Pinging @elastic/es-analytical-engine
<https://github.com/orgs/elastic/teams/es-analytical-engine>
(Team:Analytics)
—
Reply to this email directly, view it on GitHub
<#127988 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABUXIUXHVPZOV4JKG3XSBL25TPDZAVCNFSM6AAAAAB4ZRM5BSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNRXGMZTGOJQGE>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
Thanks Nik! |
💔 Backport failed
You can use sqren/backport to manually backport by running |
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
May 12, 2025
The hash aggregation operator may take time to emit the output pages, including keys and aggregated values. This change adds an emit_time field to the status. While I considered including this in hash_nanos and aggregation_nanos, having a separate section feels more natural. I am open to suggestions.
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
May 20, 2025
The hash aggregation operator may take time to emit the output pages, including keys and aggregated values. This change adds an emit_time field to the status. While I considered including this in hash_nanos and aggregation_nanos, having a separate section feels more natural. I am open to suggestions.
dnhatn
added a commit
that referenced
this pull request
May 20, 2025
The hash aggregation operator may take time to emit the output pages, including keys and aggregated values. This change adds an emit_time field to the status. While I considered including this in hash_nanos and aggregation_nanos, having a separate section feels more natural.
dnhatn
added a commit
that referenced
this pull request
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hash aggregation operator may take time to emit the output pages, including keys and aggregated values. This change adds an emit_time field to the status. While I considered including this in hash_nanos and aggregation_nanos, having a separate section feels more natural. I am open to suggestions.