System data streams incorrectly show up in the list of template validation problems #128161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masseyke
added
>bug
:Data Management/Data streams
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Hi @masseyke, I've created a changelog YAML for you. |
masseyke
added
the
auto-backport
dakrone
approved these changes
May 19, 2025
|
Oh also, since this is going to 9.0.x, can you backport to 8.18.x also? |
Co-authored-by: Lee Hinman <dakrone@users.noreply.github.com>
💔 Backport failed
You can use sqren/backport to manually backport by running |
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
May 20, 2025
…ation problems (elastic#128161) (cherry picked from commit 928fe1e) # Conflicts: # server/src/main/java/org/elasticsearch/cluster/metadata/MetadataIndexTemplateService.java # server/src/test/java/org/elasticsearch/cluster/metadata/MetadataIndexTemplateServiceTests.java # test/framework/src/main/java/org/elasticsearch/cluster/metadata/DataStreamTestHelper.java
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
May 20, 2025
…ation problems (elastic#128161) (cherry picked from commit 928fe1e) # Conflicts: # server/src/main/java/org/elasticsearch/cluster/metadata/MetadataIndexTemplateService.java # server/src/test/java/org/elasticsearch/cluster/metadata/MetadataIndexTemplateServiceTests.java # test/framework/src/main/java/org/elasticsearch/cluster/metadata/DataStreamTestHelper.java
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
May 20, 2025
…ation problems (elastic#128161) (cherry picked from commit 928fe1e) # Conflicts: # server/src/main/java/org/elasticsearch/cluster/metadata/MetadataIndexTemplateService.java # server/src/test/java/org/elasticsearch/cluster/metadata/MetadataIndexTemplateServiceTests.java # test/framework/src/main/java/org/elasticsearch/cluster/metadata/DataStreamTestHelper.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user attempts to change an index template in a way that would make a data stream no longer valid, the response incorrectly includes the names of any system data streams (such as
.fleet-actions-results) that happen to exist. For example, say I have a non-system data stream that matches a data stream templatetemplate1with priority 300. It also matches a non-data-stream templatetemplate2with priority 200, but that one is not in effect since it is lower priority. Now say I attempt to changetemplate1so that it has a priority of 100. This request will correctly fail since if we made this change my data stream would now matchtemplate2, which is an invalid state. But the response will also list all existing system data streams as part of the problem. The reason is that system data streams do not have named templates, and the API is incorrectly reporting on all data streams that do not have named templates. This fix filters out system data streams from this check.Here is an example of the incorrect error message that we currently get (
.fleet-actions-resultsought to not be listed because it is a system data stream):