Skip to content

[9.0] Fix unsupported privileges error message during role and API key creation (#128858) #129158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 11, 2025
Merged

[9.0] Fix unsupported privileges error message during role and API key creation (#128858) #129158

merged 6 commits into from
Jun 11, 2025

Conversation

gmjehovich
Copy link
Contributor

Backport of #128858

@gmjehovich gmjehovich requested a review from jfreden June 9, 2025 18:04
@gmjehovich gmjehovich added >enhancement :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC Team:Security Meta label for security team auto-backport Automatically create backport pull requests when merged v8.19.0 v8.17.8 v8.18.3 labels Jun 9, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@gmjehovich gmjehovich self-assigned this Jun 9, 2025
jfreden
jfreden reviewed Jun 10, 2025
View reviewed changes
Copy link
Contributor

@jfreden jfreden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good but you're missing the changelog and the the original PR should be in the title, so:
[9.0] Fix unsupported privileges error message during role and API key creation (#128858)

Since this is the backport PR, you also don't need the labels with all the other versions this will be backported to, that's only needed in the main PR.

@gmjehovich gmjehovich changed the title [9.0] Fix unsupported privileges error message during role and API key creation [9.0] Fix unsupported privileges error message during role and API key creation (#128858) Jun 10, 2025
jfreden
jfreden approved these changes Jun 11, 2025
View reviewed changes
Copy link
Contributor

@jfreden jfreden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmjehovich gmjehovich merged commit e649019 into elastic:9.0 Jun 11, 2025
21 checks passed
This was referenced Jun 11, 2025
Merged
Merged
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.19 Commit could not be cherrypicked due to conflicts
✅ 8.17
✅ 8.18

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 129158

@elasticsearchmachine
Copy link
Collaborator

@gmjehovich according to this PR's labels, it should not have a changelog YAML, but I can't delete it because it is closed. Please either delete the changelog from the appropriate branch yourself, or adjust the labels.

gmjehovich added a commit to gmjehovich/elasticsearch that referenced this pull request Jun 11, 2025
@gmjehovich
[9.0] Fix unsupported privileges error message during role and API ke…
491bb74 
…y creation (elastic#128858) (elastic#129158)

* Fix unsupported privileges error message during role and API key creation

* [CI] Auto commit changes from spotless

* Add changelog file

---------

Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
elasticsearchmachine pushed a commit that referenced this pull request Jun 11, 2025
@gmjehovich
[9.0] Fix unsupported privileges error message during role and API ke…
5d7bdfd 
…y creation (#128858) (#129158) (#129276)

* Fix unsupported privileges error message during role and API key creation

* [CI] Auto commit changes from spotless

* Add changelog file

---------

Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
elasticsearchmachine pushed a commit that referenced this pull request Jun 11, 2025
@gmjehovich
[9.0] Fix unsupported privileges error message during role and API ke…
3509cbb 
…y creation (#128858) (#129158) (#129274)

* Fix unsupported privileges error message during role and API key creation

* [CI] Auto commit changes from spotless

* Add changelog file

---------

Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfreden jfreden jfreden approved these changes

Assignees

@gmjehovich gmjehovich

Labels
auto-backport Automatically create backport pull requests when merged backport pending backport >enhancement :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC Team:Security Meta label for security team v8.17.8 v8.18.3 v8.19.0 v9.0.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gmjehovich @elasticsearchmachine @jfreden