Skip to content

Update traces duration mappings with appropriate unit type #129418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 16, 2025
Merged

Update traces duration mappings with appropriate unit type #129418

merged 4 commits into from
Jun 16, 2025

Conversation

Bluefinger
Copy link
Contributor

This PR is a small change/update to the span.duration.us and transaction.duration.us mappings for APM traces, simply adding the meta attributes unit to allow these to be correctly formatted as duration fields on Kibana side in Discover.

These mappings have been tested locally to work with what has been implemented here: elastic/kibana#174973

Closes elastic/kibana#217886

@Bluefinger Bluefinger requested a review from a team as a code owner June 13, 2025 15:20
@Bluefinger Bluefinger added auto-backport Automatically create backport pull requests when merged Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.19.0 v9.1.0 v9.0.3 labels Jun 13, 2025
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label and removed Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Jun 13, 2025
carsonip
carsonip reviewed Jun 13, 2025
View reviewed changes
Copy link
Member

@carsonip carsonip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this require a plugin version bump?

@Bluefinger
Copy link
Contributor Author

does this require a plugin version bump?

I'm not sure, but at least for Kibana side, it has already what it needs. The meta mapping is already being used in OTEL traces for the duration field. This is just applying that to APM duration fields.

carsonip
carsonip reviewed Jun 13, 2025
View reviewed changes
Copy link
Member

@carsonip carsonip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bluefinger Bluefinger removed the v9.0.3 label Jun 13, 2025
@Bluefinger
Copy link
Contributor Author

Bluefinger commented Jun 13, 2025 •
edited
Loading

I'll target the version 15 then?

  • Is there a specific reason why we're targeting 9.0.3? It is post-FF now. Is the coordinated UI work present in 9.0 as well?

Then I'll just remove that, leave it for the next version.

@Bluefinger Bluefinger added :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP Team:obs-ds-intake-services Meta label for Observability Intake Services team labels Jun 13, 2025
@carsonip
Copy link
Member

I'll target the version 15 then?

Sure but remember to rebase from time to time. There's at least 2 more PRs competing for version 15 (although I think it is fine as long as the plugin version changes across upgrades if there exist any changes)

Then I'll just remove that, leave it for the next version.

If you like it for 9.0.4, you may keep the PR open and only merge after 9.0.3 release

@Bluefinger Bluefinger removed the :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP label Jun 13, 2025
@elasticsearchmachine elasticsearchmachine removed the Team:obs-ds-intake-services Meta label for Observability Intake Services team label Jun 13, 2025
@Bluefinger Bluefinger added Team:obs-ds-intake-services Meta label for Observability Intake Services team :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP labels Jun 13, 2025
@elasticsearchmachine elasticsearchmachine added Team:Data Management Meta label for data/management team and removed needs:triage Requires assignment of a team area label Team:obs-ds-intake-services Meta label for Observability Intake Services team labels Jun 13, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine
Copy link
Collaborator

Hi @Bluefinger, I've created a changelog YAML for you.

@carsonip
Copy link
Member

If you like it for 9.0.4, you may keep the PR open and only merge after 9.0.3 release

Rephrasing this: if you like this in 9.0.4, please keep the 9.0.3 label, keep the backport PR open and only merge it after 9.0.3 release.

@Bluefinger
Copy link
Contributor Author

If you like it for 9.0.4, you may keep the PR open and only merge after 9.0.3 release

Rephrasing this: if you like this in 9.0.4, please keep the 9.0.3 label, keep the backport PR open and only merge it after 9.0.3 release.

Thanks and yes, it would a good idea for this to go to 9.0.4

@carsonip
Copy link
Member

Oh wait, I thought we were past 9.0.3 FF. We are not. Let's try to get it into 9.0.3. Sorry for the confusion @Bluefinger

@Bluefinger Bluefinger merged commit 78bc48e into elastic:main Jun 16, 2025
18 checks passed
@Bluefinger Bluefinger mentioned this pull request Jun 16, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
✅ 8.19
❌ 9.0 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 129418

@Bluefinger Bluefinger mentioned this pull request Jun 16, 2025
Merged
@Bluefinger
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 9.0

Questions ?

Please refer to the Backport tool documentation

@Bluefinger Bluefinger mentioned this pull request Jun 16, 2025
Closed
Bluefinger added a commit to Bluefinger/elasticsearch that referenced this pull request Jun 16, 2025
@Bluefinger
Update traces duration mappings with appropriate unit type (elastic#1…
599562f 
…29418)

(cherry picked from commit 78bc48e)

# Conflicts:
#	x-pack/plugin/apm-data/src/main/resources/resources.yaml
elasticsearchmachine pushed a commit that referenced this pull request Jun 16, 2025
@Bluefinger
Update traces duration mappings with appropriate unit type (#129418) (#…
5d2b59e 
…129468)
Bluefinger added a commit that referenced this pull request Jun 16, 2025
@Bluefinger
[9.0] Update traces duration mappings with appropriate unit type (#12…
a68caad 
…9418) (#129470)
ericywl added a commit to elastic/apm-server that referenced this pull request Jun 17, 2025
@ericywl
Add 9.0 to lazy rollover due to elastic/elasticsearch#129418
6d54ad5
@ericywl ericywl mentioned this pull request Jun 17, 2025
Merged
@rubvs rubvs mentioned this pull request Jun 19, 2025
Closed
17 tasks
ericywl added a commit to elastic/apm-server that referenced this pull request Jun 20, 2025
@ericywl
integration-server-test: Add 9.0 to lazy rollover config (#17257)
35ff144 
* Add 9.0 to lazy rollover due to elastic/elasticsearch#129418

* Remove if condition in workflow since it's skipping scheduled for some reason
@1pkg
Copy link
Member

1pkg commented Jun 23, 2025

Tested as a part of 9.1 APM Server test plan elastic/apm-server#17263.

With the old APM Server (before the changes).

image

With the new APM Server (the changes included).

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carsonip carsonip carsonip approved these changes

Assignees
No one assigned
Labels
auto-backport Automatically create backport pull requests when merged backport pending :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >enhancement Team:Data Management Meta label for data/management team v8.19.0 v9.0.3 v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Discover][APM] Better formatting for span/transaction duration fields by default
4 participants
@Bluefinger @carsonip @elasticsearchmachine @1pkg