Skip to content

[Prometheus Collector]Set ssl verification mode none and default username to empty #10088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 25, 2024
Merged

[Prometheus Collector]Set ssl verification mode none and default username to empty #10088

merged 3 commits into from
Jun 25, 2024

Conversation

gizas
Copy link
Contributor

@gizas gizas commented Jun 6, 2024

  • Enhancement

Proposed commit message

  • WHAT: Introduced ssl.verificatin_mode none and removing default password for collector metrciset
  • WHY

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  1. Clone this repo
  2. Navigate to integrations/packages/prometheus
  3. elastic-pacakge build
  4. elastic-package stack up -d -v --version=8.14.0
  5. Install prometheus integration with following parameters
    Screenshot 2024-06-06 at 1 14 27 PM

Screenshot 2024-06-06 at 1 10 55 PM

  1. Set SSL Verification mode : not

Related issues

Screenshots

Screenshot 2024-06-06 at 10 33 08 AM

@gizas gizas requested a review from MichaelKatsoulis June 6, 2024 11:55
@gizas gizas mentioned this pull request Jun 6, 2024
Open
tetianakravchenko
tetianakravchenko reviewed Jun 11, 2024
View reviewed changes
@gizas @tetianakravchenko
Update packages/prometheus/data_stream/collector/manifest.yml
629aa6b 
Co-authored-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@gizas gizas marked this pull request as ready for review June 12, 2024 07:01
@gizas gizas requested a review from a team as a code owner June 12, 2024 07:01
@gizas
Copy link
Contributor Author

gizas commented Jun 25, 2024

@elastic/obs-infraobs-integrations can you please have a look here?

devamanv
devamanv reviewed Jun 25, 2024
View reviewed changes
@gizas @devamanv
Update packages/prometheus/changelog.yml
c1a293a 
Co-authored-by: Aman <38116245+devamanv@users.noreply.github.com>
@elasticmachine
Copy link

💚 Build Succeeded

History

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

devamanv
devamanv approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@devamanv devamanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gizas gizas merged commit 3702a31 into main Jun 25, 2024
5 checks passed
@gizas gizas deleted the prometheusssl branch June 25, 2024 13:05
@elasticmachine
Copy link

Package prometheus - 1.15.3 containing this change is available at https://epr.elastic.co/search?package=prometheus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tetianakravchenko tetianakravchenko tetianakravchenko left review comments

@devamanv devamanv devamanv approved these changes

@MichaelKatsoulis MichaelKatsoulis Awaiting requested review from MichaelKatsoulis

Assignees
No one assigned
Labels
Integration:prometheus Prometheus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gizas @elasticmachine @tetianakravchenko @devamanv @andrewkroh