-
Notifications
You must be signed in to change notification settings - Fork 474
[Logstash] Add pipeline info to pipeline screen #10164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit adds additional information from the `pipelines` endpoint to the `pipeline` data_stream
9bd130a
to
2d5bf53
Compare
🚀 Benchmarks reportTo see the full report comment with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job 💯 Left some questions and I am trying to test the change. I am using elastic-package to build the integration and elastic-package stack up -d
but I am not sure that this will work with Logstash - I installed the integration in Kibana (latest version 2.4.10) and enabled self-monitoring. Do you know if I need to do something else to see the changes?
packages/logstash/kibana/dashboard/logstash-a42d7060-45e6-11ee-957b-3720c0b0fbc5.json
Show resolved
Hide resolved
packages/logstash/data_stream/pipeline/agent/stream/cel.yml.hbs
Outdated
Show resolved
Hide resolved
@jennypavlova Thanks for the review! This should be able to be tested using |
|
💚 Build Succeeded
History
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the changes!
Probably my local setup is not working correctly because I don't see any values in the dashboards. The code looks good to me. 🎉
This should be able to be tested using elastic-package stack up -d, with stack.logstash_enabled: true setup in the config.yml to bring up a logstash. Then setting up the integration with the agent pointing to localhost:9600, and the "technical preview" metrics radio button checked should install the dashboards, and have new entries showing in "Pipelines Overview"
I built the package and I followed the steps but maybe I missed something:
Screen.Recording.2024-06-18.at.19.34.27.mov
And http://localhost:9600/_node returns:
Apologies - if you are using the |
@robbavey Thank you for the instructions! I did that and with |
Package logstash - 2.4.10 containing this change is available at https://epr.elastic.co/search?package=logstash |
Proposed commit message
This commit adds pipeline information to the Pipelines View. This involves retrieving the
info
object from thepipelines
view to retrieveephemeral_id
,workers
,batch_size
andbatch_delay
for each pipeline.Additionally, this commit adds a table to the Pipelines View to show
workers
,batch_size
,batch_delay
, the type of queue being used, and the current size of the queue if it is a persistent queueChecklist
changelog.yml
file.How to test this PR locally
Install the integration, and point to a recent version of Logstash. Verify that the Pipelines View shows the correct data for each pipeline
Screenshots