-
Notifications
You must be signed in to change notification settings - Fork 474
AWS: TargetResponseTime metrics added to Application elb #10181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💚 CLA has been signed |
/test |
1 similar comment
/test |
I understand this is a simple enhancement. Is there a plan to display the newly added field under the existing dashboard? This change must be considered alongside other issues mentioned here, especially the challenges of dashboarding for ELB metrics and logs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviews shared.
Please regenerate the README, checkin the README changes to avoid buildkite failure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments added
/test |
🚀 Benchmarks reportTo see the full report comment with |
@lucabelluccini : I think this was the customer enhancement request you were discussing with me. |
Co-authored-by: Gabriel Pop <94497545+gpop63@users.noreply.github.com>
💚 Build Succeeded
History
|
|
Reply to @agi comment: #10181 (comment) I had discussion with @agi and according to @agithomas Customers are often getting confused with empty fields in their dashboard.There is ongoing issue to split elb data stream into 3 different data streams: application_elb, network_elb, and classic_elb as mentioned in this ticket #4800. I have also created backlog ticket for create a dashboard panel for ALB. |
Based on my discussion with @anil-elastic , i understand the field is relevant when an ALB is configured. Adding a dashboard panel at this stage will add more problems to the customers as mentioned here. Hence the #10326 is created as a backlog issue, which can be taken up along with the enhancement request of separate OOTB dashboards for various LBs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Package aws - 2.16.0 containing this change is available at https://epr.elastic.co/search?package=aws |
Proposed commit message
Added TargetResponseTime metrics in AWS Application ELB.
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
I've tested with elastic-package, and run the tests and TargetResponseTime comes into elb metrics.
Screenshots