Skip to content

AWS: TargetResponseTime metrics added to Application elb #10181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 2, 2024

Conversation

anil-elastic
Copy link
Contributor

@anil-elastic anil-elastic commented Jun 18, 2024

Proposed commit message

Added TargetResponseTime metrics in AWS Application ELB.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

I've tested with elastic-package, and run the tests and TargetResponseTime comes into elb metrics.

"aws": {
      "applicationelb": {
        "metrics": {
          "HealthyHostCount": {
            "max": 1
          },
          "RequestCount": {
            "sum": 4
          },
          "TargetResponseTime": {
            "avg": 0.0014383333333333333
          },
          "UnHealthyHostCount": {
            "max": 0
          }
        }
      },

Screenshots

@anil-elastic anil-elastic requested review from a team as code owners June 18, 2024 17:07
Copy link

cla-checker-service bot commented Jun 18, 2024

💚 CLA has been signed

@anil-elastic
Copy link
Contributor Author

/test

1 similar comment
@gpop63
Copy link
Contributor

gpop63 commented Jun 18, 2024

/test

@agithomas
Copy link
Contributor

I understand this is a simple enhancement.

Is there a plan to display the newly added field under the existing dashboard?

This change must be considered alongside other issues mentioned here, especially the challenges of dashboarding for ELB metrics and logs.

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviews shared.

@agithomas
Copy link
Contributor

Please regenerate the README, checkin the README changes to avoid buildkite failure.

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments added

@anil-elastic
Copy link
Contributor Author

/test

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@ishleenk17
Copy link
Member

@lucabelluccini : I think this was the customer enhancement request you were discussing with me.
The PR is already in works for adding the TargetResponseTime metric.

Co-authored-by: Gabriel Pop <94497545+gpop63@users.noreply.github.com>
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @anil-elastic

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@anil-elastic anil-elastic requested a review from agithomas July 2, 2024 08:34
@anil-elastic
Copy link
Contributor Author

Reply to @agi comment: #10181 (comment)

I had discussion with @agi and according to @agithomas Customers are often getting confused with empty fields in their dashboard.There is ongoing issue to split elb data stream into 3 different data streams: application_elb, network_elb, and classic_elb as mentioned in this ticket #4800.

I have also created backlog ticket for create a dashboard panel for ALB.
#10326

@agithomas
Copy link
Contributor

I understand this is a simple enhancement.

Is there a plan to display the newly added field under the existing dashboard?

This change must be considered alongside other issues mentioned here, especially the challenges of dashboarding for ELB metrics and logs.

Based on my discussion with @anil-elastic , i understand the field is relevant when an ALB is configured.

Adding a dashboard panel at this stage will add more problems to the customers as mentioned here.

Hence the #10326 is created as a backlog issue, which can be taken up along with the enhancement request of separate OOTB dashboards for various LBs

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anil-elastic anil-elastic merged commit 0eb2de5 into elastic:main Jul 2, 2024
5 checks passed
@elasticmachine
Copy link

Package aws - 2.16.0 containing this change is available at https://epr.elastic.co/search?package=aws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TargetResponseTime metric in ELB agent configuration,
5 participants