Skip to content

o365: Increase CEL tracer log count #10233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Conversation

kcreddy
Copy link
Contributor

@kcreddy kcreddy commented Jun 25, 2024

Proposed commit message

Increase request tracer log count to 10.

For large tenants, when CEL program makes a series of requests,
we have seen cases where the tracer logs wouldn't capture a full 
list of responses even during a single interval because of limitation 
on number of tracer logs. This leads to lack of visibility if certain 
requests return non-200 response, leading to data loss. Increasing 
the tracer logs count to 10 from 5.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@kcreddy kcreddy changed the title o265: Increase CEL tracer log count o365: Increase CEL tracer log count Jun 25, 2024
@kcreddy kcreddy self-assigned this Jun 25, 2024
@kcreddy kcreddy added enhancement New feature or request Integration:o365 Microsoft Office 365 labels Jun 25, 2024
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @kcreddy

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

@kcreddy kcreddy marked this pull request as ready for review June 25, 2024 07:55
@kcreddy kcreddy requested a review from a team as a code owner June 25, 2024 07:55
@kcreddy kcreddy added the Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] label Jun 25, 2024
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@kcreddy kcreddy merged commit c425128 into elastic:main Jun 25, 2024
5 checks passed
@elasticmachine
Copy link

Package o365 - 2.5.0 containing this change is available at https://epr.elastic.co/search?package=o365

@kcreddy kcreddy deleted the o365_tracers branch February 7, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:o365 Microsoft Office 365 Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants