Skip to content

[IIS] Add processors capability to IIS Metrics #10285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 1, 2024
Merged

[IIS] Add processors capability to IIS Metrics #10285

merged 3 commits into from
Jul 1, 2024

Conversation

mholttech
Copy link
Contributor

@mholttech mholttech commented Jun 27, 2024 •
edited by ishleenk17
Loading

Proposed commit message

Add processors capability to IIS Metrics

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

How to test this PR locally

Related issues

Screenshots

@cla-checker-service CLA Checker Service
Copy link

cla-checker-service bot commented Jun 27, 2024 •
edited
Loading

💚 CLA has been signed

@mholttech
Copy link
Contributor Author

just signed CLA

@mholttech mholttech marked this pull request as ready for review June 27, 2024 18:28
@mholttech mholttech requested a review from a team as a code owner June 27, 2024 18:28
@mholttech mholttech changed the title Add processors capability to IIS Metrics [IIS] Add processors capability to IIS Metrics Jun 27, 2024
@mholttech mholttech force-pushed the iis-add-processors branch from 78ecd9f to d0e9655 Compare June 27, 2024 18:37
@bvader bvader mentioned this pull request Jun 27, 2024
Closed
@bvader bvader added Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] enhancement New feature or request labels Jun 27, 2024
@ishleenk17
Copy link
Member

/test

@elasticmachine
Copy link

elasticmachine commented Jun 28, 2024 •
edited
Loading

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

ishleenk17
ishleenk17 reviewed Jul 1, 2024
View reviewed changes
@ishleenk17
Copy link
Member

@mholttech : Please update the link, otherwise the change looks good!

@muthu-mps
Copy link
Contributor

@ishleenk17 -

  • The documentation link is the only change that I see which needs to be addressed because the older link points to the Filebeat processor which is only specific to logs data stream.

@mholttech
Copy link
Contributor Author

@ishleenk17 & @muthu-mps - I've updated the processor description as requested.

@ishleenk17
Copy link
Member

/test

@elasticmachine
Copy link

💚 Build Succeeded

History

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

ishleenk17
ishleenk17 approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ishleenk17 ishleenk17 merged commit 28a2a6f into elastic:main Jul 1, 2024
5 checks passed
@elasticmachine
Copy link

Package iis - 1.19.0 containing this change is available at https://epr.elastic.co/search?package=iis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishleenk17 ishleenk17 ishleenk17 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Integration:iis IIS Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[IIS] Add processors to application_pool, webserver, and website metrics datastreams
6 participants
@mholttech @ishleenk17 @elasticmachine @muthu-mps @andrewkroh @bvader