-
Notifications
You must be signed in to change notification settings - Fork 474
[OpenCanary] Correct issue with remove
processors for source and destination ports
#10288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
remove
processors for source and destination portsremove
processors for source and destination ports
/test |
🚀 Benchmarks reportTo see the full report comment with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit then LGTM
packages/opencanary/data_stream/events/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
/test |
💚 Build Succeeded
History
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Package opencanary - 0.1.1 containing this change is available at https://epr.elastic.co/search?package=opencanary |
Type of Change:
Proposed commit message
Fixes and issue where all source and destination details were removed if the source or destination port was an invalid "-1". The intent was to remove
source.port
if the value was "-1", ordestination.port
if the value was "-1". Theremove
processors were removing the rootsource
ordestination
fields.integrations/packages/opencanary/data_stream/events/elasticsearch/ingest_pipeline/default.yml
Lines 736 to 749 in 466ca32
Checklist
changelog.yml
file.Related issues