Skip to content

[OpenCanary] Correct issue with remove processors for source and destination ports #10288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 1, 2024
Merged

[OpenCanary] Correct issue with remove processors for source and destination ports #10288

merged 3 commits into from
Jul 1, 2024

Conversation

MakoWish
Copy link
Contributor

@MakoWish MakoWish commented Jun 27, 2024

Type of Change:

  • Bug

Proposed commit message

Fixes and issue where all source and destination details were removed if the source or destination port was an invalid "-1". The intent was to remove source.port if the value was "-1", or destination.port if the value was "-1". The remove processors were removing the root source or destination fields.

- remove:
description: Remove malformed source.* fields for LOG_BASE_MSG events
tag: remove_source_port
field: source
if: ctx.source?.port == -1
ignore_missing: true
ignore_failure: true
- remove:
description: Remove malformed destination.* fields for LOG_BASE_MSG events
tag: remove_destination_port
field: destination
if: ctx.destination?.port == -1
ignore_missing: true
ignore_failure: true

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@MakoWish MakoWish requested a review from a team as a code owner June 27, 2024 22:35
@MakoWish MakoWish changed the title Correct issue with remove processors for source and destination ports [OpenCanary] Correct issue with remove processors for source and destination ports Jun 27, 2024
@efd6
Copy link
Contributor

efd6 commented Jun 27, 2024

/test

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit then LGTM

Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
@efd6
Copy link
Contributor

efd6 commented Jul 1, 2024

/test

@elasticmachine
Copy link

💚 Build Succeeded

History

Copy link

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@efd6 efd6 merged commit c2ceb26 into elastic:main Jul 1, 2024
5 checks passed
@elasticmachine
Copy link

Package opencanary - 0.1.1 containing this change is available at https://epr.elastic.co/search?package=opencanary

@andrewkroh andrewkroh added the Integration:opencanary OpenCanary (Community supported) label Jul 19, 2024
@MakoWish MakoWish deleted the opencanary_pipeline_fixes branch February 4, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:opencanary OpenCanary (Community supported)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] OpenCanary Beta Integration Pipeline Issues
4 participants