Skip to content

[O11y][AWS] Add global filter for dashboards to improve performance of AWS Integration package #10324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

milan-elastic
Copy link
Contributor

  • Enhancement

Proposed commit message

Added global filter for below dashboards to improve performance,

  • [Logs AWS] API Gateway Overview (Unlinked saved search hence screenshot is not required)
  • [Logs AWS] CloudTrail (Unlinked saved search hence screenshot is not required)
  • [Logs AWS] ELB Access Log Overview
  • [Logs AWS] EMR Overview (Unlinked saved search hence screenshot is not required)
  • [Metrics AWS] EMR Overview
  • [Metrics AWS] S3 Overview
  • [Metrics AWS] Overview

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

[Logs AWS] ELB Access Log Overview
Before After
Logs AWS  ELB Access Log Overview - Before Logs AWS  ELB Access Log Overview - After
[Metrics AWS] EMR Overview
Before After
Metrics AWS  EMR Overview - Before Metrics AWS  EMR Overview - after
[Metrics AWS] S3 Overview
Before After
metrics aws  s3 overview - before metrics aws  s3 overview - after
[Metrics AWS] Overview
Before After
aws  metrics overview - before aws  metrics overview - after

@milan-elastic milan-elastic added the enhancement New feature or request label Jul 2, 2024
@milan-elastic milan-elastic self-assigned this Jul 2, 2024
@ali786XI
Copy link
Contributor

ali786XI commented Jul 4, 2024

/test

2 similar comments
@ali786XI
Copy link
Contributor

ali786XI commented Jul 4, 2024

/test

@ali786XI
Copy link
Contributor

ali786XI commented Jul 4, 2024

/test

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@milan-elastic
Copy link
Contributor Author

/test

@milan-elastic milan-elastic marked this pull request as ready for review July 16, 2024 06:12
@milan-elastic milan-elastic requested review from a team as code owners July 16, 2024 06:12
Copy link

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌🏼

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @milan-elastic

Copy link

@agithomas agithomas changed the title [O11y][AWS] Add global filter for dashboards to improve performance related to infraobs packages [O11y][AWS] Add global filter for dashboards to improve performance of AWS Integration package Aug 2, 2024
@agithomas
Copy link
Contributor

As you have already taken the screenshot, are you planning to update the package screenshot images (with the dataset filter)

@agithomas
Copy link
Contributor

Curious, why the error count, total count, and throttled count appear with decimal places.

Are there issues with the formula? If there is a problem, kindly create a backlog issue for further analysis.

image

@harnish-crest-data
Copy link
Contributor

Curious, why the error count, total count, and throttled count appear with decimal places.

Are there issues with the formula? If there is a problem, kindly create a backlog issue for further analysis.

image

Created backlog issue #10695

@harnish-crest-data
Copy link
Contributor

As you have already taken the screenshot, are you planning to update the package screenshot images (with the dataset filter)

No, the dashboards having only change of filter. Also we have used mock data as well to populate some panels to cross check there are no issues after adding the filter.

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harnish-crest-data harnish-crest-data merged commit 3be250b into elastic:main Aug 5, 2024
5 checks passed
@elasticmachine
Copy link

Package aws - 2.22.0 containing this change is available at https://epr.elastic.co/search?package=aws

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
…f AWS Integration package (elastic#10324)

* Add global filter for dashboards to improve performance related to infraobs packages

* Update changelog entry

* Minor refactor for changelog entry
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
…f AWS Integration package (elastic#10324)

* Add global filter for dashboards to improve performance related to infraobs packages

* Update changelog entry

* Minor refactor for changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:aws AWS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants