Skip to content

Add Processor Support #10410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 15, 2024
Merged

Add Processor Support #10410

merged 5 commits into from
Jul 15, 2024

Conversation

Linu-Elias
Copy link
Contributor

@Linu-Elias Linu-Elias commented Jul 8, 2024 •
edited by harnish-crest-data
Loading

Proposed commit message

Adding Processor Support for the following Packages

  • Etcd
  • HAProxy
  • InfluxDB
  • Kafka
  • Memcached
  • Microsoft SQL Server
  • MongoDB
  • MYSQL
  • Nginx

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@Linu-Elias Linu-Elias requested a review from a team as a code owner July 8, 2024 13:06
@Linu-Elias Linu-Elias added enhancement New feature or request bugfix Pull request that fixes a bug issue and removed enhancement New feature or request labels Jul 8, 2024
@elasticmachine
Copy link

elasticmachine commented Jul 8, 2024 •
edited
Loading

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@Linu-Elias
Copy link
Contributor Author

/test

@ali786XI ali786XI changed the title Add Processot Support Add Processor Support Jul 9, 2024
@harnish-crest-data harnish-crest-data self-requested a review July 9, 2024 07:10
@Linu-Elias Linu-Elias added enhancement New feature or request and removed bugfix Pull request that fixes a bug issue labels Jul 9, 2024
harnish-crest-data
harnish-crest-data approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@harnish-crest-data harnish-crest-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
50.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @Linu-Elias

@devamanv
Copy link
Contributor

Just one comment about the inconsistent use of blank lines when adding the processors. I see there's a blank line before it at some places, while others don't. Rest looks good.

@Linu-Elias Linu-Elias merged commit 1a0ab9e into elastic:main Jul 15, 2024
4 of 5 checks passed
@elasticmachine
Copy link

Package etcd - 1.3.0 containing this change is available at https://epr.elastic.co/search?package=etcd

@elasticmachine
Copy link

Package haproxy - 1.14.0 containing this change is available at https://epr.elastic.co/search?package=haproxy

@elasticmachine
Copy link

Package influxdb - 0.10.0 containing this change is available at https://epr.elastic.co/search?package=influxdb

@elasticmachine
Copy link

Package kafka - 1.16.0 containing this change is available at https://epr.elastic.co/search?package=kafka

@elasticmachine
Copy link

Package memcached - 1.6.0 containing this change is available at https://epr.elastic.co/search?package=memcached

@elasticmachine
Copy link

Package microsoft_sqlserver - 2.8.0 containing this change is available at https://epr.elastic.co/search?package=microsoft_sqlserver

@elasticmachine
Copy link

Package mongodb - 1.16.0 containing this change is available at https://epr.elastic.co/search?package=mongodb

@elasticmachine
Copy link

Package mysql - 1.23.0 containing this change is available at https://epr.elastic.co/search?package=mysql

@elasticmachine
Copy link

Package nginx - 1.23.0 containing this change is available at https://epr.elastic.co/search?package=nginx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devamanv devamanv devamanv approved these changes

@harnish-crest-data harnish-crest-data harnish-crest-data approved these changes

Assignees

@Linu-Elias Linu-Elias

Labels
enhancement New feature or request Integration:etcd etcd Integration:haproxy HAProxy Integration:influxdb InfluxDb Integration:kafka Kafka Integration:memcached Memcached Integration:microsoft_sqlserver Microsoft SQL Server Integration:mongodb MongoDB Integration:mysql MySQL Integration:nginx Nginx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Linu-Elias @elasticmachine @devamanv @harnish-crest-data @andrewkroh