Skip to content

[integrations][keycloak] - Fixed parser config default value and updated GROK pattern to account for multiline error logs #10549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

ShourieG
Copy link
Contributor

@ShourieG ShourieG commented Jul 22, 2024

Type of change

  • Bug

Proposed commit message

  1. The default parser regex pattern was faulty based on the parser requirements, hence updated it accordingly.
  2. The existing GROK pattern did not pick up multiline error logs, hence updated it accordingly and regenerated tests reflecting the change.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • URL extention detections seems to have stopped after the change, and the extention is part of the url now.

NOTE:

I revisited the url extention issue and seems even after a revert the extension field is no longer generated. This seems it might not be related to this change but rather how url extensions are now handled in ecs. It seems only file extensions are parsed now instead of a ".path". (could be wrong)

How to test this PR locally

Related issues

Screenshots

@ShourieG ShourieG requested a review from a team as a code owner July 22, 2024 13:26
@ShourieG ShourieG self-assigned this Jul 22, 2024
@ShourieG ShourieG added the Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] label Jul 22, 2024
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@ShourieG ShourieG added integration Label used for meta issues tracking each integration bugfix Pull request that fixes a bug issue labels Jul 22, 2024
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

Copy link

@elasticmachine
Copy link

💚 Build Succeeded

cc @ShourieG

@ShourieG ShourieG requested a review from efd6 July 22, 2024 14:20
@andrewkroh andrewkroh added the Integration:keycloak Keycloak (Community supported) label Jul 22, 2024
@ShourieG ShourieG removed the request for review from efd6 July 23, 2024 05:38
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShourieG ShourieG merged commit 2c1ef36 into elastic:main Jul 23, 2024
5 checks passed
@ShourieG ShourieG deleted the bugfix/keycloak branch July 23, 2024 06:29
@elasticmachine
Copy link

Package keycloak - 1.22.1 containing this change is available at https://epr.elastic.co/search?package=keycloak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:keycloak Keycloak (Community supported) integration Label used for meta issues tracking each integration Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants