[Prometheus] Added dynamic_<dataset|namespace> settings to prometheus datasets #10592
Conversation
andrewkroh
added
Integration:prometheus
|
@andrewkroh or anyone else: Could you please run the CI tests? Thank you |
|
/test |
|
@andrewkroh Could you please run the CI again? Also is there anyone from elastic-obs-infra-obs I can tag, that may review this PR (as it is open quite a while now and only introduces a small quality of life improvement)? |
|
/test |
|
Kindly asking for review, because this PR is open quite a while now. @elastic/obs-infraobs-integrations |
|
@muthu-mps Im just tagging you as you reviewed my other PR. Could you review this one aswell or is this the reponsibility of a different member of infraobs-integrations? Thank you in advance |
Thanks @Alphayeeeet. I am tagging @ishleenk17 to take a look into this PR. |
|
Hi @ishleenk17 just tagging you again to remind for this PR. We are currently blocked in our internal implementation by the rerouting feature. Thank you |
|
@ishleenk17 If this change could also be useful for the other datasets, I can implement them aswell. But in our currently used structure, only the collector is used as we reroute based on Kubernetes annotations (like already possible with the kubernetes.container_logs dataset of the Kubernetes integration). |
…om/Alphayeeeet/integrations into prometheus-add-reroute-permissions
andrewkroh
added
the
Team:Cloudnative-Monitoring
Alphayeeeet
changed the title
|
@ishleenk17 @tetianakravchenko @MichaelKatsoulis any updates on this PR by now? |
|
/test |
|
@tetianakravchenko : Please check from remote write perspective. |
💚 Build Succeeded
History
|
|
|
@ishleenk17 & @tetianakravchenko Could you please review and approve the PR if possible? Still waiting for this change and we are still blocked in our metrics implementation... |
|
@elastic/obs-ds-hosted-services : Please check this. |
|
@tetianakravchenko any updates on this PR? |
You have all the needed approvals. We can go ahead and merge it now. |
|
Package prometheus - 1.19.0 containing this change is available at https://epr.elastic.co/search?package=prometheus |
|
@ishleenk17 Thanks. unfortunately the auto merge did not work, and im not permitted to merge in general. Thank you anyway |
… datasets (elastic#10592) * Added dynamic_<dataset|namespace> settings to collector dataset * Added PR url * Corrected comment in manifest.yml * Added rerouting permissions for remote-write/query datasets and changed changelog message
… datasets (elastic#10592) * Added dynamic_<dataset|namespace> settings to collector dataset * Added PR url * Corrected comment in manifest.yml * Added rerouting permissions for remote-write/query datasets and changed changelog message
Please label as Enhancement
This PR allows using prometheus datasets as a generic metric datasets in e.g. Kubernetes environments, as it adds the permissions to write to metrics--. This allows the configuration of annotation based rerouting in ingest pipelines like it is used in kubernetes.container_logs.
If needed, we can add a default rerouting mechanism, based on the kubernetes annotations like it is already provided in kubernetes.container_logs.
If necessary, we can add a generic metric dataset with this setting to the Kubernetes integration instead of using the Prometheus package for that.