Skip to content

AWS Fargate: Add disclaimer that integration supports ECS only #10613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 31, 2024

Conversation

zmoog
Copy link
Contributor

@zmoog zmoog commented Jul 26, 2024

Proposed commit message

Clarify the AWS Fargate integration documentation, saying that this integration supports Amazon ECS clusters only. Unfortunately, today, it does not support EKS clusters managing nodes with a Fargate profile.

More than one user contacted the support team, asking why the AWS Fargate doesn't work on the EKS cluster. The docs state that it works with ECS clusters only, but more is needed.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@andrewkroh andrewkroh added Integration:awsfargate AWS Fargate (for ECS clusters) Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Jul 26, 2024
@zmoog zmoog self-assigned this Jul 26, 2024
@zmoog zmoog added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Jul 26, 2024
@zmoog zmoog requested a review from alaudazzi July 26, 2024 15:16
@zmoog zmoog marked this pull request as ready for review July 26, 2024 15:16
@zmoog zmoog requested a review from a team as a code owner July 26, 2024 15:16
Copy link

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @zmoog

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@alaudazzi alaudazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zmoog zmoog merged commit ffa063f into elastic:main Jul 31, 2024
5 checks passed
@zmoog zmoog deleted the zmoog/aws-fargate-ecs-only branch July 31, 2024 16:16
@elasticmachine
Copy link

Package awsfargate - 1.2.1 containing this change is available at https://epr.elastic.co/search?package=awsfargate

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:awsfargate AWS Fargate (for ECS clusters) Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants