Skip to content

[cisco_ftd]: support usernames with spaces for message ids 716002 and 722051 #10635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pkoutsovasilis
Copy link
Contributor

@pkoutsovasilis pkoutsovasilis commented Jul 29, 2024

Proposed commit message

This PR allows cisco_ftd to parse correctly usernames with a space for log entries that wrap the username with angle brackets.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

N/A

How to test this PR locally

elastic-package test pipeline

Related issues

Screenshots

N/A

@pkoutsovasilis pkoutsovasilis changed the title fix: support usernames with spaces for message ids 716002 and 722051 [cisco_ftd]: support usernames with spaces for message ids 716002 and 722051 Jul 29, 2024
@pkoutsovasilis pkoutsovasilis self-assigned this Jul 29, 2024
@pkoutsovasilis pkoutsovasilis added bug Something isn't working, use only for issues Integration:cisco_ftd Cisco FTD Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Jul 29, 2024
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @pkoutsovasilis

Copy link

@pkoutsovasilis pkoutsovasilis marked this pull request as ready for review July 29, 2024 10:46
@pkoutsovasilis pkoutsovasilis requested a review from a team as a code owner July 29, 2024 10:46
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@pkoutsovasilis pkoutsovasilis merged commit 88a4359 into elastic:main Aug 1, 2024
5 checks passed
@pkoutsovasilis pkoutsovasilis deleted the pkoutsovasilis/cisco_ftd_username_with_spaces branch August 1, 2024 15:34
@elasticmachine
Copy link

Package cisco_ftd - 3.3.1 containing this change is available at https://epr.elastic.co/search?package=cisco_ftd

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
… 722051 (elastic#10635)

* fix: support usernames with spaces for message ids 716002 and 722051

* feat: update pull request link in changelog.yml
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
… 722051 (elastic#10635)

* fix: support usernames with spaces for message ids 716002 and 722051

* feat: update pull request link in changelog.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Integration:cisco_ftd Cisco FTD Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration:CiscoFTD Grok error on ftd message ID 722051 - incorrect grok pattern
3 participants