mimecast: add message release logs data stream #10732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
enhancement
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
dlp_logs |
13888.89 | 7751.94 | -6136.95 (-44.19%) | 💔 |
siem_logs |
4484.3 | 3773.58 | -710.72 (-15.85%) | 💔 |
To see the full report comment with /test benchmark fullreport
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
kcreddy
reviewed
Aug 8, 2024
| "risk_score": 12, | ||
| "type": [ | ||
| "info" | ||
| ] |
There was a problem hiding this comment.
Could possibly add email.local_id and email.subject from id and subject fields respectively.
| @@ -0,0 +1,159 @@ | |||
| - name: mimecast | |||
There was a problem hiding this comment.
Does having all fields at package-level, i.e., mimecast instead of datastream-level mimecast.message_release_logs cause any datatype conflicts between datastreams?
There was a problem hiding this comment.
The other data streams in the package place things at the mimecast root, so I was following that pattern. I can move this data stream to its own namespace and file an issue to move the others (this would be a breaking change). WDYT?
There was a problem hiding this comment.
I just checked. Interesting that there are no collisions so far, but also could be they have a good mapping and field naming conventions across different datasets. I am leaning towards leaving it be as is, I don't want to bring about breaking changes when nothing is broken yet.
| show_user: false | ||
| default: | ||
| - forwarded | ||
| - mimecast-siem-logs |
There was a problem hiding this comment.
Suggested change
| - mimecast-siem-logs | |
| - mimecast-message-release-logs |
...ast/data_stream/message_release_logs/_dev/test/pipeline/test-release-logs.json-expected.json
Show resolved
Hide resolved
kcreddy
approved these changes
Aug 9, 2024
|
💚 Build Succeeded
History
cc @efd6 |
|
Package mimecast - 1.27.0 containing this change is available at https://epr.elastic.co/search?package=mimecast |
ltflb-bgdi
pushed a commit
to geoadmin/infra-elastic-integrations
that referenced
this pull request
Aug 22, 2024
ltflb-bgdi
pushed a commit
to geoadmin/infra-elastic-integrations
that referenced
this pull request
Sep 6, 2024
anil-elastic
pushed a commit
that referenced
this pull request
Sep 10, 2024
* mimecast: add message release logs data stream (#10732) * Fix AWS cloudfront log parsing * Refactored cloudfront parser * Updated aws cloudfront testlogs * Updated aws cloudfront logs test config * Moved cloudfront.content_type to http.response.mime_type * Added field mapping for aws.cloudfront range fields. * Fixed edge_detailed_result_type * Updated cloudfront.md * Implemented review recommendations * Updated cloudfront_logs system test log file * Fixed CI problems * Update sample_event.json * Update cloudfront.md * formatted and build with newest elastic-package version * Revert changes fixed by formatters * Update sample_event.json * Added review recommendations * Beautified some pipeline conditionals * Added additional cloudfront test case * Fixed test-default-config hit count --------- Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 4, 2025
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 4, 2025
* mimecast: add message release logs data stream (elastic#10732) * Fix AWS cloudfront log parsing * Refactored cloudfront parser * Updated aws cloudfront testlogs * Updated aws cloudfront logs test config * Moved cloudfront.content_type to http.response.mime_type * Added field mapping for aws.cloudfront range fields. * Fixed edge_detailed_result_type * Updated cloudfront.md * Implemented review recommendations * Updated cloudfront_logs system test log file * Fixed CI problems * Update sample_event.json * Update cloudfront.md * formatted and build with newest elastic-package version * Revert changes fixed by formatters * Update sample_event.json * Added review recommendations * Beautified some pipeline conditionals * Added additional cloudfront test case * Fixed test-default-config hit count --------- Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 5, 2025
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 5, 2025
* mimecast: add message release logs data stream (elastic#10732) * Fix AWS cloudfront log parsing * Refactored cloudfront parser * Updated aws cloudfront testlogs * Updated aws cloudfront logs test config * Moved cloudfront.content_type to http.response.mime_type * Added field mapping for aws.cloudfront range fields. * Fixed edge_detailed_result_type * Updated cloudfront.md * Implemented review recommendations * Updated cloudfront_logs system test log file * Fixed CI problems * Update sample_event.json * Update cloudfront.md * formatted and build with newest elastic-package version * Revert changes fixed by formatters * Update sample_event.json * Added review recommendations * Beautified some pipeline conditionals * Added additional cloudfront test case * Fixed test-default-config hit count --------- Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
See title.
Note that this is not tested against a real endpoint.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots