[suricata] Handle empty tls data #10756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible for Suricata logs to have app_proto=tls, but not provide a tls object. This will handle this case by checking for the existing of the tls object before running the tls pipeline that parses this object.
andrewkroh
added
Integration:suricata
|
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
andrewkroh
approved these changes
Aug 9, 2024
packages/suricata/data_stream/eve/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
…e/default.yml Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
History
cc @mjwolf |
|
|
Package suricata - 2.21.2 containing this change is available at https://epr.elastic.co/search?package=suricata |
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 4, 2025
It's possible for Suricata logs to have app_proto=tls, but not provide a tls object. This will handle this case by checking for the existing of the tls object before running the tls pipeline that parses this object. --------- Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 5, 2025
It's possible for Suricata logs to have app_proto=tls, but not provide a tls object. This will handle this case by checking for the existing of the tls object before running the tls pipeline that parses this object. --------- Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
It's possible for Suricata logs to have app_proto=tls, but not provide a tls object. This will handle this case by checking for the existing of the tls object before running the tls pipeline that parses this object.
Checklist
changelog.ymlfile.