Skip to content

entityanalytics_ad: expose paging size configuration to user #10762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Aug 12, 2024

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • Corresponding configuration is here.

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:entityanalytics_ad Active Directory Entity Analytics labels Aug 12, 2024
@efd6 efd6 self-assigned this Aug 12, 2024
@efd6 efd6 force-pushed the b40482-entityanalytics_ad branch from d915e5a to 844d93d Compare August 12, 2024 02:56
Copy link

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @efd6

@efd6 efd6 marked this pull request as ready for review August 12, 2024 03:13
@efd6 efd6 requested a review from a team as a code owner August 12, 2024 03:13
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@@ -5,6 +5,9 @@ ad_base_dn: {{ad_base_dn}}
ad_url: {{ad_url}}
ad_user: {{ad_user}}
ad_password: {{ad_password}}
{{#if paging_size}}
ad_paging_size: {{paging_size}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ad_paging_size is missing from the input reference docs. Can you please add that at some point.

Copy link
Contributor Author

@efd6 efd6 Aug 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@efd6 efd6 merged commit 8a059ca into elastic:main Aug 12, 2024
5 checks passed
@elasticmachine
Copy link

Package entityanalytics_ad - 0.2.0 containing this change is available at https://epr.elastic.co/search?package=entityanalytics_ad

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@efd6 efd6 deleted the b40482-entityanalytics_ad branch February 5, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:entityanalytics_ad Active Directory Entity Analytics Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants